Unittests do not succeed with random PYTHONHASHSEED value

[Clark Boylan]

New tox and python3.3 set a random PYTHONHASHSEED value by default. These projects should support this in their unittests so that we do not have to override the PYTHONHASHSEED value and potentially let bugs into these projects.

To reproduce these failures:

# install latest tox
pip install --upgrade tox
tox --version # should report 1.7.2 or greater
cd $PROJECT_REPO
# edit tox.ini to remove any PYTHONHASHSEED=0 lines
tox -epy27

Most of these failures appear to be related to dict entry ordering.

[Kiall Mac Innes (kiall)]

Designate master: https://review.openstack.org/#/c/109740/
Designate stable/icehouse: https://review.openstack.org/#/c/109744/

[Joshua Harlow (harlowja)]

I believe this also will happen with python 2.7.3 (not just 3.3).

https://www.python.org/download/releases/2.7.3/

http://bugs.python.org/issue13703

[pritesh (pritesh)]

seems to be already fixed here: https://review.openstack.org/#/c/109729/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109888

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109895

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109939

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/109994

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110014

[Dolph Mathews (dolph)]

I haven't seen this as an issue in Keystone yet - is there anything I need to do to reproduce it other than run tox 1.7.2?

[Dolph Mathews (dolph)]

My first attempt to reproduce this was a complete fail on my part... I easily reproduced on the second attempt, and confirmed the workaround.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110039

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110039
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=61b44eaceb3f57ef1d34e6a358398e36f49ba396
Submitter: Jenkins
Branch: master

commit 61b44eaceb3f57ef1d34e6a358398e36f49ba396
Author: Dolph Mathews <email address hidden>
Date: Mon Jul 28 15:55:51 2014 +0000

    Add workaround to support tox 1.7.2

    Change-Id: I58542f6e7dbbad98517c09b6176b9827f66dd1ff
    Partial-Bug: 1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110408

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109939
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b056fca27897947ce5ef1326ee19db767f14f0ae
Submitter: Jenkins
Branch: master

commit b056fca27897947ce5ef1326ee19db767f14f0ae
Author: Dmitry Tantsur <email address hidden>
Date: Mon Jul 28 11:23:12 2014 +0200

    Do not rely on hash ordering in tests

    With tox 1.7.2 hash randomization will be on by default, causing
    random failures of our tests. How to reproduce:
    * Update tox
    * Run something like:
      $ for i in {1..20}; do tox -epy27 || break; done

    Change-Id: I52c10c47a7a1c0e6a9e436efb090bbcb0fb02edc
    Closes-bug: #1348818

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rakesh H S (<email address hidden>) on branch: master
Review: https://review.openstack.org/110408

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109888
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c83207ec9726bee2ba295f2a25228b2ac5a89b6d
Submitter: Jenkins
Branch: master

commit c83207ec9726bee2ba295f2a25228b2ac5a89b6d
Author: Henry Gessau <email address hidden>
Date: Sun Jul 27 21:01:46 2014 -0400

    Functional tests work fine with random PYTHONHASHSEED

    Partial-bug: #1348818

    Change-Id: Iccac403585635851c6d121d6e27c1c90b0de5acb

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109994
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=3a009031be349fb20738ba295a63c2fc2cefa4fd
Submitter: Jenkins
Branch: master

commit 3a009031be349fb20738ba295a63c2fc2cefa4fd
Author: Chris Dent <email address hidden>
Date: Mon Jul 28 12:34:35 2014 +0100

    Fix dict and set order related issues in tests

    There are several tests where the expected output
    relies on order of strings generated from the arbitrary
    ordering of dictionaries or sets. The new version of
    tox causes that ordering to be different between tests
    runs so tests must be resilient and test either the
    content of the dicts or sets or their sorted output.

    Note: These fixes are only of those cases where a failure
    was generated. If there are issues in skipped tests, this
    patch has not found nor fixed them. The vast majority of
    skipped tests are related to availability of functionality
    so there's little that can be done about that with the
    current testing setup. The best we can do is be on the
    lookout for failures that could be related PYTHONHASHSEED
    down the road and fix them as they happen.

    Closes-Bug: 1348818
    Change-Id: I6b27ca2597c51b0656f441f325f9ffd0e31a606d

[John Vrbanac (john.vrbanac)]

jfyi:
I was able to reliably reproduce two errors with the Barbican tests when running tox locally setting PYTHONHASHSEED=1742787125

Local Tox Output: http://paste.openstack.org/show/89674/
Tox Version: 1.7.2
Barbican Git commit id: e0c542d158128301de3ef778739fd3c313c253e6

When I set the PYTHONHASHSEED=0 these errors stop coming up.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110233
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=edd887da5b66dfd3428be552e4b7d5bf66343783
Submitter: Jenkins
Branch: master

commit edd887da5b66dfd3428be552e4b7d5bf66343783
Author: Christian Berendt <email address hidden>
Date: Tue Jul 29 10:21:59 2014 +0200

    Set python hash seed to 0 in tox.ini

    New tox (>=1.7.0) sets a random python hash seed by default. This is
    generally good for testing because it will help keep projects working
    regardless of the hash seed, but nova unittests don't currently pass
    with a random hash seed so set it to the python default seed.

    This change will allow us to use new tox again and remove the
    restriction on tox<=1.6.1 to run unittests.

    Also see Ib54364877a251db48c54dfdc43c503281ea1f04a.

    Change-Id: I68695d8bd01a5a2ea683c6da2e1ad248ec69c710
    Closes-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111589

[Dolph Mathews (dolph)]

Neutron, ironic and ceilometer have so far produced actual fixes for this issue. I re-opened this bug against designate and barbican because the associated patches merely set PYTHONHASHSEED=0 rather than fixing the test suites to work with a random hash seed.

If you're going to apply the workaround to set PYTHONHASHSEED=0, please use Partial-Bug or Related-Bug in your commit message rather than Closes-Bug, so that the bot does not set the task status to Fix Committed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111711

[Henry Gessau (gessau)]

Neutron has many many affected test cases.
I thought it would be better to spread the work out, so I created this:
https://etherpad.openstack.org/p/neutron-random-hashseed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111589
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5c93dfaf25c81576ddc664d2d30ef8297eb367e1
Submitter: Jenkins
Branch: master

commit 5c93dfaf25c81576ddc664d2d30ef8297eb367e1
Author: Henry Gessau <email address hidden>
Date: Sun Aug 3 13:40:01 2014 -0400

    Do not assume order of quotas dictionary elements

    This fixes the quotas db unit test that breaks with a randomized PYTHONHASHSEED
    (see the bug report).

    The test assumed that the quotas dictionary from plugin.get_all_quotas() had
    elements in a particular order. Found with PYTHONHASHSEED=1235130571.

    The fix refactors the test case to handle an unsorted quotas dictionary. Also
    choose some different quota limits to make it clearer what is being verified.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: I3892b51082629e6ebce175f64f501717741baa37

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111711
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5db7c77def326264579f8db3238372b0351407f2
Submitter: Jenkins
Branch: master

commit 5db7c77def326264579f8db3238372b0351407f2
Author: Henry Gessau <email address hidden>
Date: Mon Aug 4 08:47:08 2014 -0400

    Add a tox test environment for random hashseed testing

    The newer versions of tox by default enable a random PYTHONHASHSEED. However,
    this breaks many Neutron unit tests, so PYTHONHASHSEED=0 is currently hard-
    coded for Neutron's unit test environments.

    We want to clean up the unit test cases that break with a random hashseed
    (there are many). To be able to find the broken tests and then verify them,
    we need to have an easy way of enabling random hashseed testing.

    Partial-bug: #1348818

    Change-Id: I51f05cdfa9f8728baabaf315b71e5defb26426b1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111886

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111924

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111822
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=31783e2eae339e79225f379ace948a0bb6c157f7
Submitter: Jenkins
Branch: master

commit 31783e2eae339e79225f379ace948a0bb6c157f7
Author: Pritesh Kothari <email address hidden>
Date: Mon Aug 4 13:37:56 2014 -0700

    Do not assume order of network_uuid's

    This fixes the neutron.tests.unit.test_linux_dhcp.TestDnsmasq
    .test_existing_dhcp_networks unit test that breaks with a
    randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the network_uuid's list was sorted, so sort
    the result before comparing.

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Partial-bug: #1348818
    Change-Id: Ia6f742e1fae0687164b841beebb4efcf31ff2625

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111809
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ce567d7410aa92b09072a8030c89ab9d52707e86
Submitter: Jenkins
Branch: master

commit ce567d7410aa92b09072a8030c89ab9d52707e86
Author: armando-migliaccio <email address hidden>
Date: Mon Aug 4 12:24:19 2014 -0700

    Make _build_uri_path output predictable

    This is done by ensuring that filters are
    serialized in their alphabetical order.

    Tweak tests affected by this.

    This is done in the context as defined by
    etherpad: neutron-random-hashseed

    Partial-bug: #1348818

    Change-Id: Ibe79716a340195ca0365f276ef6e3e728f1a94a1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110014
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b30072e47ead3625cbf29a3b2955cae19a8e7533
Submitter: Jenkins
Branch: master

commit b30072e47ead3625cbf29a3b2955cae19a8e7533
Author: Christian Berendt <email address hidden>
Date: Mon Jul 28 17:03:51 2014 +0200

    Set python hash seed to 0 in tox.ini

    New tox (>=1.7.0) sets a random python hash seed by default. This is
    generally good for testing because it will help keep projects working
    regardless of the hash seed, but nova unittests don't currently pass
    with a random hash seed so set it to the python default seed.

    This change will allow us to use new tox again and remove the
    restriction on tox<=1.6.1 to run unittests.

    Also see Ib54364877a251db48c54dfdc43c503281ea1f04a.

    Change-Id: I8834487e8c7bcdbeae8397c1a10a18873976ce61
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111835
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b0f68bb14531b74f54cad6106491ff75b0e8a1d8
Submitter: Jenkins
Branch: master

commit b0f68bb14531b74f54cad6106491ff75b0e8a1d8
Author: Pritesh Kothari <email address hidden>
Date: Mon Aug 4 14:14:20 2014 -0700

    Do not assume order of pci slot list

    This fixes the neutron.tests.unit.sriovnicagent.test_eswitch_manager
    .TestEmbSwitch.test_get_pci_list unit test that breaks with a
    randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the pci slot list was sorted, so sort
    the result before comparing.

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: Ia2d879cc1251fb9cf9b653a41064e902b30005af
    Partial-bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111886
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=6cf1c81a60e8f2e50cb530e45521c61999355ff8
Submitter: Jenkins
Branch: master

commit 6cf1c81a60e8f2e50cb530e45521c61999355ff8
Author: Kiall Mac Innes <email address hidden>
Date: Mon Aug 4 18:53:30 2014 -0700

    Ensure Object change lists are sorted during to_primitive

    This ensures our tests succeed with a random PYTHONHASHSEED value.

    Change-Id: I798e0b91f2e515562188b5d14cd7ce2055bd64fb
    Partial-Bug: 1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114194

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112258
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f103ce48ca60e12952be7aa6d5183f64ef826370
Submitter: Jenkins
Branch: master

commit f103ce48ca60e12952be7aa6d5183f64ef826370
Author: Sam Betts <email address hidden>
Date: Wed Aug 6 00:05:05 2014 +0100

    Predictable field and filter ordering

    This fixes the fields and filters units tests that break with a
    randomized PYTHONHASHSEED (see the bug report).

    The RESOURCE_ATTRIBUTE_MAP is stored as a dict leading to an
    unpredictable output order. Values in kvp strings are being stored as
    sets underpinned by dicts when converted, leading to unpredictable
    ordering of values when read.

    Discovered with PYTHONHASHSEED = 2455351445 on these tests:
    test_api_v2.APIv2TestCase.test_fields
    test_api_v2.APIv2TestCase.test_fields_multiple
    test_api_v2.FiltersTestCase.test_attr_info_with_convert_list_to
    test_api_v2.APIv2TestCase.test_filters_with_fields
    test_api_v2.APIv2TestCase.test_fields_multiple_with_empty

    There are 3 parts to this fix:
    1. Update the APIv2TestCase _do_field_list function to construct
    field list in the same order as the controller constructs its list.
    2. Ensure the APIv2TestCase _get_collection_kwargs maintains order
    throughout.
    3. Use new assertOrderedEqual function to sort values before assertion
    in test_attr_info_with_convert_list_to

    Change-Id: I547cfa80cf83b0340b459279df9283443562326b
    Partial-bug: #1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114582

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112034
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c353a26fb36b97bdc369bd41e0f23a8bbf2a2ea8
Submitter: Jenkins
Branch: master

commit c353a26fb36b97bdc369bd41e0f23a8bbf2a2ea8
Author: John Davidge <email address hidden>
Date: Tue Aug 5 15:13:03 2014 +0100

    Do not assume order of new_peers list elements

    This fixes the vpn unit test that breaks with a randomized PYTHONHASHSEED
    (see the bug report).

    The test assumed that the new_peers list from self.new_update_request had
    elements in a particular order. Found with PYTHONHASHSEED=2455351445.

    The fix refactors the test case to handle an unsorted new_peers list by
    sorting it before running the test.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: I86e7f84cedbdc8e1d7404363a560fd759d264c49

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114582
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=68f5243e23f8768d8996d0268eae282ccb3cb83c
Submitter: Jenkins
Branch: master

commit 68f5243e23f8768d8996d0268eae282ccb3cb83c
Author: Louis Taylor <email address hidden>
Date: Fri Aug 15 15:43:36 2014 +0000

    Do not assume order of images

    This fixes the test_tag_lifecycle test, which broke with a randomized
    PYTHONHASHSEED.

    Previously, the test assumed that the values in the list of tag names
    would remain constant. The test now sorts the results and compares to a
    sorted set.

    Change-Id: If5a2ef683fcf55520c7d539f1b90aefaba4739d5
    Partial-bug: #1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115132

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114194
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=66c987479ae3485d308ec3505a6a6b7404736f1c
Submitter: Jenkins
Branch: master

commit 66c987479ae3485d308ec3505a6a6b7404736f1c
Author: Louis Taylor <email address hidden>
Date: Thu Aug 14 10:21:36 2014 +0000

    Ensure constant order when setting all image tags

    The newer version of tox (>=1.7.0) sets a random hash seed, which makes the
    order of sets unpredictable. This patchset fixes the test_image_tag_set_all
    test, which otherwise broke with a randomized PYTHONHASHSEED. This new tox
    behaviour is consistent with python (>=3.3), meaning this change should avoid
    bugs on that platform at a later date.

    Change-Id: Ie281b04fc9c4c2a96a9eec9bde7b05229ebf57fc
    Partial-bug: #1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/115342

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/115926

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/115932

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/115941

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/115947

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115926
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=050e766b02862fb901f393826031c4b7c6613cbb
Submitter: Jenkins
Branch: stable/havana

commit 050e766b02862fb901f393826031c4b7c6613cbb
Author: Christian Berendt <email address hidden>
Date: Mon Jul 28 17:03:51 2014 +0200

    Set python hash seed to 0 in tox.ini

    New tox (>=1.7.0) sets a random python hash seed by default. This is
    generally good for testing because it will help keep projects working
    regardless of the hash seed, but horizon unittests don't currently pass
    with a random hash seed so set it to the python default seed.

    This change will allow us to use new tox again and remove the
    restriction on tox<=1.6.1 to run unittests.

    Also see Ib54364877a251db48c54dfdc43c503281ea1f04a.

    Change-Id: I8834487e8c7bcdbeae8397c1a10a18873976ce61
    Partial-Bug: #1348818
    (cherry picked from commit b30072e47ead3625cbf29a3b2955cae19a8e7533)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fei Long Wang (<email address hidden>) on branch: master
Review: https://review.openstack.org/116240
Reason: Fix the issue in https://review.openstack.org/#/c/115342

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115941
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=30f9247269980c6860ee8b68ac766371bf114276
Submitter: Jenkins
Branch: stable/icehouse

commit 30f9247269980c6860ee8b68ac766371bf114276
Author: Dolph Mathews <email address hidden>
Date: Mon Jul 28 15:55:51 2014 +0000

    Add workaround to support tox 1.7.2

    Change-Id: I58542f6e7dbbad98517c09b6176b9827f66dd1ff
    Partial-Bug: 1348818
    (cherry picked from commit 61b44eaceb3f57ef1d34e6a358398e36f49ba396)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115947
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=dc089f73b380e7f6ec71a90f62b56474bb8ad10b
Submitter: Jenkins
Branch: stable/havana

commit dc089f73b380e7f6ec71a90f62b56474bb8ad10b
Author: Dolph Mathews <email address hidden>
Date: Mon Jul 28 15:55:51 2014 +0000

    Add workaround to support tox 1.7.2

    Conflicts:
     tox.ini

    Change-Id: I58542f6e7dbbad98517c09b6176b9827f66dd1ff
    Partial-Bug: 1348818
    (cherry picked from commit 61b44eaceb3f57ef1d34e6a358398e36f49ba396)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115932
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b6d6e156f842c6882762ff38b13879111a243c6e
Submitter: Jenkins
Branch: stable/icehouse

commit b6d6e156f842c6882762ff38b13879111a243c6e
Author: Christian Berendt <email address hidden>
Date: Mon Jul 28 17:03:51 2014 +0200

    Set python hash seed to 0 in tox.ini

    New tox (>=1.7.0) sets a random python hash seed by default. This is
    generally good for testing because it will help keep projects working
    regardless of the hash seed, but horizon unittests don't currently pass
    with a random hash seed so set it to the python default seed.

    This change will allow us to use new tox again and remove the
    restriction on tox<=1.6.1 to run unittests.

    Also see Ib54364877a251db48c54dfdc43c503281ea1f04a.

    Change-Id: I8834487e8c7bcdbeae8397c1a10a18873976ce61
    Partial-Bug: #1348818
    (cherry picked from commit b30072e47ead3625cbf29a3b2955cae19a8e7533)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116352
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=74a38b5e7ea69f9730845e71c34fafdb7733c60b
Submitter: Jenkins
Branch: master

commit 74a38b5e7ea69f9730845e71c34fafdb7733c60b
Author: John Griffith <email address hidden>
Date: Fri Aug 22 11:52:36 2014 -0600

    Fix duplicate teardown to allow tox upgrade

    When trying to use tox 1.7.2 we run into a second
    tearDown call being made in the test as opposed to
    just using Super's version of it.

    This removes that call and seems to get everything
    working under tox 1.7.2

    Change-Id: I0a2674b7c1ba9589cab5e3b76777fce23b6601ad
    Partial-Bug: 1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/116560

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/116562

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115342
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=65c4e73104cc89706256098fc0e07ee0024b43aa
Submitter: Jenkins
Branch: master

commit 65c4e73104cc89706256098fc0e07ee0024b43aa
Author: Louis Taylor <email address hidden>
Date: Tue Aug 19 15:52:24 2014 +0000

    Fix collection order issues and unit test failures

    A randomized PYTHONHASHSEED caused the glance API to return certain data
    in a nondeterministic order, breaking some tests. This patch sorts the
    returned data before testing against a pre-sorted expected values.

    This patch also fixes some unit test failures with the new version of
    testtools (0.9.36) and directly calling setUp(). This was added to this
    patch to avoid blocking more Glance tests.

    Co-authored-by: Fei Long Wang <email address hidden>
    Co-authored-by: Zhi Yan Liu <email address hidden>

    Partial-bug: #1348818

    Change-Id: Ie92c6bb5663826713ca99e8f2f7d70f3faef6675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116560
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=bba31d0560f868bca72389bb0ca3ca08789a228b
Submitter: Jenkins
Branch: stable/icehouse

commit bba31d0560f868bca72389bb0ca3ca08789a228b
Author: Louis Taylor <email address hidden>
Date: Tue Aug 19 15:52:24 2014 +0000

    Fix collection order issues and unit test failures

    A randomized PYTHONHASHSEED caused the glance API to return certain data
    in a nondeterministic order, breaking some tests. This patch sorts the
    returned data before testing against a pre-sorted expected values.

    This patch also fixes some unit test failures with the new version of
    testtools (0.9.36) and directly calling setUp(). This was added to this
    patch to avoid blocking more Glance tests.

    Co-authored-by: Fei Long Wang <email address hidden>
    Co-authored-by: Zhi Yan Liu <email address hidden>

    Conflicts:
     glance/tests/unit/common/test_wsgi.py

    Partial-bug: #1348818
    Change-Id: Ie92c6bb5663826713ca99e8f2f7d70f3faef6675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116562
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=26a14511ef3828a0d67ab808803180a85eb7c8f4
Submitter: Jenkins
Branch: stable/havana

commit 26a14511ef3828a0d67ab808803180a85eb7c8f4
Author: Louis Taylor <email address hidden>
Date: Tue Aug 19 15:52:24 2014 +0000

    Fix collection order issues and unit test failures

    A randomized PYTHONHASHSEED caused the glance API to return certain data
    in a nondeterministic order, breaking some tests. This patch sorts the
    returned data before testing against a pre-sorted expected values.

    This patch also fixes some unit test failures with the new version of
    testtools (0.9.36) and directly calling setUp(). This was added to this
    patch to avoid blocking more Glance tests.

    Co-authored-by: Fei Long Wang <email address hidden>
    Co-authored-by: Zhi Yan Liu <email address hidden>

    Icehouse-Conflicts:
     glance/tests/unit/common/test_wsgi.py

    Havana-Conflicts:
     glance/tests/integration/legacy_functional/test_v1_api.py
     glance/tests/unit/common/test_wsgi.py
     glance/tests/unit/test_glance_replicator.py
     glance/tests/unit/test_vmware_store.py
     glance/tests/unit/v2/test_images_resource.py
     glance/tests/unit/v2/test_tasks_resource.py

    Partial-bug: #1348818
    Change-Id: Ie92c6bb5663826713ca99e8f2f7d70f3faef6675

[gordon chung (chungg)]

changing status for ceilometer as we had to add back in hashseed. WSME sphinxext dependency was causing gate-ceilometer-doc errors

see: http://lists.openstack.org/pipermail/openstack-dev/2014-August/043668.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112853
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9ce1935d06b2822a34ffb1234bc994acf306ad32
Submitter: Jenkins
Branch: master

commit 9ce1935d06b2822a34ffb1234bc994acf306ad32
Author: Ilya Shakhat <email address hidden>
Date: Fri Aug 8 16:48:22 2014 +0400

    Do not assume order of parameters in OVSBridge.add_flow call

    This fixes neutron.tests.unit.agent.linux.test_ovs_lib.OVS_Lib_Test.test_add_flow
    unit test that breaks with a randomized PYTHONHASHSEED.

    The test assumed that the parameters passed to add_flow had
    elements in a particular order. Found with PYTHONHASHSEED=2455351445.
    The fix refactors the test case to match parameters as set.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: Ibe2f4d929b8b42c8c909c2306d2554faf7109b49

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109895
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9e3111250bceece8e36cd9fe60b80393515aa423
Submitter: Jenkins
Branch: master

commit 9e3111250bceece8e36cd9fe60b80393515aa423
Author: Henry Gessau <email address hidden>
Date: Sat Jul 26 22:05:02 2014 -0400

    Predictable iptables chains output order

    This fixes the iptables unit tests that break with a randomized PYTHONHASHSEED
    (see the bug report).

    The chains for iptables are stored as sets to avoid duplicates. When they are
    output by iptables_manager their order can therefore be unpredictable. This was
    found hash seed 1016732220.

    To fix this we:
     - Sort the chains output by iptables_manager
     - Update the unit tests to check for sorted chains

    When multiple tables are processed, they can be processed in any order or
    dumped in any order. Found with hash seed 3728666619.

    To fix this we:
     - Traverse the tables in sorted order for dumping
     - Fix tests to allow for tables to be processed in any order

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Partial-bug: #1348818

    Change-Id: Ic3f4cd85316c9fc2e78bc7f5e900cfac87baf39d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/115132
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=ede2ea5f6a0e079a75d2b0c8bfee2b0fc1482063
Submitter: Jenkins
Branch: master

commit ede2ea5f6a0e079a75d2b0c8bfee2b0fc1482063
Author: Andrew Lazarev <email address hidden>
Date: Mon Aug 18 15:13:51 2014 -0700

    Fix some of tests that rely on hash ordering

    With tox 1.7.2 hash randomization will be on by default, causing
    random failures of tests. How to reproduce:
    * Update tox
    * Remove "PYTHONHASHSEED=0" from tox.ini
    * Run something like:
      $ for i in {1..20}; do tox -epy27 || break; done

    Changes:
    * Made most of generated stuff predictable by adding sorting

    Not done:
    * Current API validation checks nothing relying on specific response for
      specific hash. I tried to test it based on regexp patterns but it
      looks like more discussion is needed. See
      https://review.openstack.org/#/c/112736/ for more details. This patch
      is a part that can be done without regexps.

    Change-Id: I92a714cf9c29547e875170547a6c0625ddaebc88
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111924
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5ae2d9145be180ad2e8df7e887091a7fbad8fb08
Submitter: Jenkins
Branch: master

commit 5ae2d9145be180ad2e8df7e887091a7fbad8fb08
Author: Kevin Benton <email address hidden>
Date: Tue Aug 5 00:04:33 2014 -0600

    Ensure assertion matches dict iter order in test

    Fixes a test_linux_ip_lib test that made an assertion
    on a command that was called that could fail depending
    on the order of the dictionary when it was iterated over.

    This patch makes the assertion match the order that the
    command is constructed by iterating through the dictionary
    as well.

    Partial-Bug: #1348818
    Change-Id: I7baa518169c193f7e98d38632e1db16eb57ffee7

[Nikhil Manchanda (slicknik)]

Fix proposed for the Trove unit tests.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/118914

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118914
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=a0c0370c14b34004314a89df3c2cd85adbe8c8e3
Submitter: Jenkins
Branch: master

commit a0c0370c14b34004314a89df3c2cd85adbe8c8e3
Author: Andrew Lazarev <email address hidden>
Date: Wed Sep 3 15:19:52 2014 -0700

    Removed comment about hashseed reset in unit tests

    Comment is not actual after removing hash seed reset

    Related-Bug: #1348818

    Change-Id: I20a3c336842e8801eb446b8c83fa08b07f9de2f3

[Akihiro Motoki (amotoki)]

python-neutronclient review https://review.openstack.org/#/c/110991/ has been merged.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120823

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ryan Hsu (<email address hidden>) on branch: master
Review: https://review.openstack.org/121711
Reason: Testing

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112296
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=979d8118577c59a2dfe8c3ebd268fb3863aa4b26
Submitter: Jenkins
Branch: master

commit 979d8118577c59a2dfe8c3ebd268fb3863aa4b26
Author: Bradley Jones <email address hidden>
Date: Wed Aug 6 14:16:23 2014 +0100

    Do not assume order of device_ids set elements

    This fixes the test_ancillary_bridges_multiple unit test that breaks with a randomized
    PYTHONHASHSEED (see the bug report).
    The test assumed that the device_ids set had
    elements in a particular order. Found with PYTHONHASHSEED=2455351445.

    The fix refactors the pullup_side_effect function so that it checks if the
    device_id exists before returning the bridge.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: Ie6b44d1d820ebb186036ffcd04ea2104dd384e94

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/121386
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=7ab190338d7b41bc6ae057a2a2f2e1e3f30038e7
Submitter: Jenkins
Branch: master

commit 7ab190338d7b41bc6ae057a2a2f2e1e3f30038e7
Author: John Vrbanac <email address hidden>
Date: Sat Sep 13 14:54:03 2014 -0500

    Fixing the PYTHONHASHSEED bug with our unittests

    Switching from HTTPInternalServerError to HTTPServerError
    as Pecan seems to be returning HTTPServerError instead.
    For some reason the assertion only fails with specific
    PYTHONHASHSEED's. As a result, I'm just making sure we
    assert against the returned exception to correct the
    issue for the moment.

    Change-Id: Iad15fa17fc2c4d5c3642462df25e702aaff4801f
    Partial-bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112248
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d5b90315d2ff647179fd91512377a7f21a57ef0a
Submitter: Jenkins
Branch: master

commit d5b90315d2ff647179fd91512377a7f21a57ef0a
Author: Jacek Swiderski <email address hidden>
Date: Wed Aug 6 11:23:16 2014 +0200

    Do not assume order of body and tags elements

    This fixes the l2gateway unit test that breaks with a randomized PYTHONHASHSEED
    (see the bug report).

    The test assumed that the body dict from self._create_expected_req_body
    had elements (including contents of tags list) in a particular order.
    Found with PYTHONHASHSEED=2455351445.
    The fix ensures that body is in predictable order.

    Partial-bug: #1348818
    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: I423b68aff58486c113d0e5c5f4726f9eabf6920e

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/124703

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eoghan Glynn (<email address hidden>) on branch: master
Review: https://review.openstack.org/124703
Reason: Duplicates https://review.openstack.org/120823

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112836
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2abb77b4dadd4150f554f134ec99b07c2b28900f
Submitter: Jenkins
Branch: master

commit 2abb77b4dadd4150f554f134ec99b07c2b28900f
Author: johndavidge <email address hidden>
Date: Fri Aug 8 04:48:59 2014 -0700

    Do not assume order of report list elements

    This fixes the test_report_multiple_services unit test that breaks with a
    randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the report list from self.driver.report_status() had
    elements in a particular order. Found with PYTHONHASHSEED=2455351445.

    The fix refactors the test case to handle an unsorted report list by
    sorting it before checking equality.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: I542c3818821fa2f6e460fd254a3842530ecea8d9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/126822

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/126822
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c2625f5d8f3e612d59b0e47c417625d879fef575
Submitter: Jenkins
Branch: stable/icehouse

commit c2625f5d8f3e612d59b0e47c417625d879fef575
Author: Dmitry Tantsur <email address hidden>
Date: Mon Jul 28 11:23:12 2014 +0200

    Do not rely on hash ordering in tests

    With tox 1.7.2 hash randomization will be on by default, causing
    random failures of our tests. How to reproduce:
    * Update tox
    * Run something like:
      $ for i in {1..20}; do tox -epy27 || break; done

    Closes-bug: #1348818
    (cherry picked from commit b056fca27897947ce5ef1326ee19db767f14f0ae)

    Conflicts:
     ironic/tests/api/v1/test_drivers.py

    NOTE(adam_g): The following changes had to be tacked on here to get
    through the stable/icehouse gate:

        * .testr.conf is also updated to exclude the in-tree Nova
           driver tests, which were never run until Juno and are
           breaking test runs for stable/icehouse.

        * tox.ini is updated to specify PYTHONHASHSEED=0 for doc builds,
          backported from 2abea080f617928af6386074e121aba33db2fe33.

    Change-Id: I52c10c47a7a1c0e6a9e436efb090bbcb0fb02edc

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/112079
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8fac816e407dd87d4c940d2a0c873f78933b8cdc
Submitter: Jenkins
Branch: master

commit 8fac816e407dd87d4c940d2a0c873f78933b8cdc
Author: Bradley Jones <email address hidden>
Date: Tue Aug 5 17:55:44 2014 +0100

    Do not assume order of lvm.tun_ofports set elements

    This fixes the test_fdb_add_flows unit test that breaks with a randomized PYTHONHASHSEED
    (see the bug report).

    The test assumed that the lvm.tun_ofports set had
    elements in a particular order. Found with PYTHONHASHSEED=2455351445 and
    1595538922.

    The fix sorts the actions output string so that it is always sorted when the
    outputs are compared.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: I86b453a93f3ba09212709caf462cf3bfc5b21ee9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/129562

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/129584

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/129597

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/130175

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129584
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ab0992cf5303752f054ad4d47f0a949aadbea83a
Submitter: Jenkins
Branch: master

commit ab0992cf5303752f054ad4d47f0a949aadbea83a
Author: Bradley Jones <email address hidden>
Date: Mon Oct 20 12:34:55 2014 +0100

    Ensure ofagent unit tests handles random hashseeds

    Several tests in test_ofa_neutron_agent.py and test_ofa_flows.py fail when
    running the unit tests with hashseed 2701526934.

    This patch fixes the failing unit tests by specifying that assert_has_calls does
    not need to assert any order.

    Change-Id: I48d6601130f7de1f6eeb7333a17eddd82e7acbdf
    Partial-Bug: 1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/lbaasv2
Review: https://review.openstack.org/130864

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/130864
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c089154a94e5872efc95eab33d3d0c9de8619fe4
Submitter: Jenkins
Branch: feature/lbaasv2

commit 62588957fbeccfb4f80eaa72bef2b86b6f08dcf8
Author: Kevin Benton <email address hidden>
Date: Wed Oct 22 13:04:03 2014 -0700

    Big Switch: Switch to TLSv1 in server manager

    Switch to TLSv1 for the connections to the backend
    controllers. The default SSLv3 is no longer considered
    secure.

    TLSv1 was chosen over .1 or .2 because the .1 and .2 weren't
    added until python 2.7.9 so TLSv1 is the only compatible option
    for py26.

    Closes-Bug: #1384487
    Change-Id: I68bd72fc4d90a102003d9ce48c47a4a6a3dd6e03

commit 17204e8f02fdad046dabdb8b31397289d72c877b
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Oct 22 06:20:15 2014 +0000

    Imported Translations from Transifex

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I58db0476c810aa901463b07c42182eef0adb5114

commit d712663b99520e6d26269b0ca193527603178742
Author: Carl Baldwin <email address hidden>
Date: Mon Oct 20 21:48:42 2014 +0000

    Move disabling of metadata and ipv6_ra to _destroy_router_namespace

    I noticed that disable_ipv6_ra is called from the wrong place and that
    in some cases it was called with a bogus router_id because the code
    made an incorrect assumption about the context. In other case, it was
    never called because _destroy_router_namespace was being called
    directly. This patch moves the disabling of metadata and ipv6_ra in
    to _destroy_router_namespace to ensure they get called correctly and
    avoid duplication.

    Change-Id: Ia76a5ff4200df072b60481f2ee49286b78ece6c4
    Closes-Bug: #1383495

commit f82a5117f6f484a649eadff4b0e6be9a5a4d18bb
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Oct 21 12:11:19 2014 +0000

    Updated from global requirements

    Change-Id: Idcbd730f5c781d21ea75e7bfb15959c8f517980f

commit be6bd82d43fbcb8d1512d8eb5b7a106332364c31
Author: Angus Lees <email address hidden>
Date: Mon Aug 25 12:14:29 2014 +1000

    Remove duplicate import of constants module

    .. and enable corresponding pylint check now the only offending instance
    is fixed.

    Change-Id: I35a12ace46c872446b8c87d0aacce45e94d71bae

commit 9902400039018d77aa3034147cfb24ca4b2353f6
Author: rajeev <email address hidden>
Date: Mon Oct 13 16:25:36 2014 -0400

    Fix race condition on processing DVR floating IPs

    Fip namespace and agent gateway port can be shared by multiple dvr routers.
    This change uses a set as the control variable for these shared resources
    and ensures that Test and Set operation on the control variable are
    performed atomically so that race conditions do not occur among
    multiple threads processing floating IPs.
    Limitation: The scope of this change is limited to addressing the race
    condition described in the bug report. It may not address other issues
    such as pre-existing issue wit...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129562
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1da765d791cbbb03bcc49f2d0a9437ec2b71ac54
Submitter: Jenkins
Branch: master

commit 1da765d791cbbb03bcc49f2d0a9437ec2b71ac54
Author: Sam Betts <email address hidden>
Date: Mon Oct 20 10:59:13 2014 +0100

    Ensure test_agent_manager handles random hashseeds

    Several tests in test_agent_manager.py fail when tox is run using the
    hashseed 2701526934, this is down to the nature of using dictionaries
    and sets in Python causing some function calls and function arguments
    to be out of order. This patch fixes this by either specifying that
    assert_has_calls does not need to assert the order, just that the calls
    were made, or by letting the unit test get affected in the same way as
    the code, e.g. add variables to a dict so they are ordered by the python
    hashing algorithms in the same way as they would be in the real code.

    Change-Id: If83d1f33c187eab45c2a65fd50fd70cce011c9e7
    Partial-Bug: 1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136593

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/130175
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d8ee3055eeffb8779caf2fb355ab4b84d5b280db
Submitter: Jenkins
Branch: master

commit d8ee3055eeffb8779caf2fb355ab4b84d5b280db
Author: John Davidge <email address hidden>
Date: Wed Oct 22 02:28:52 2014 -0700

    Fix PYTHONHASHSEED bugs in test_security_groups_rpc

    This fixes the test_security_groups_rpc unit test that breaks with a
    randomized PYTHONHASHSEED (see the bug report).

    The test assumed that several Dicts had elements in a particular order.
    Found with PYTHONHASHSEED=2701526934.

    The fix refactors the test case by using an OrderedDict instead of a Dict.
    Or in the case of the regex strings, injecting different values depending
    on the order of the devices2 and devices3 Dicts.

    An upstream spelling mistake is also addressed in this patch.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with a
    randomized PYTHONHASHSEED, but they are not addressed here. They will be
    addressed in separate patches.

    Change-Id: I744117edfc5869b0750349a89f2792f622e4285d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138918

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138919

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138920

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138921

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138922

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138923

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129597
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=706deaeaed3c9b8ccd71500590c8d3b3cff5802e
Submitter: Jenkins
Branch: master

commit 706deaeaed3c9b8ccd71500590c8d3b3cff5802e
Author: Sam Betts <email address hidden>
Date: Mon Oct 20 13:26:33 2014 +0100

    Ensure test_metaplugin handles random hashseeds

    2 tests fail in test_metaplugin when using hashseed 2701526934 this is
    down to the nature of using dictionaries and sets in Python having
    unpredictable ordering when retrieving data stored in them. This patch
    ensures that no matter the order fake1 and fake2 get placed into
    self.plugins that the test can assert both possible scenarios.

    Change-Id: I65fa6979cc0d6e3531e50f249c53db6be83a6cfe
    Partial-Bug: 1348818

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brant Knudson (<email address hidden>) on branch: master
Review: https://review.openstack.org/138918
Reason: XML isn't supported anymore

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138919
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=658b175beff723f8e2a0a38da3ef4e7979f92539
Submitter: Jenkins
Branch: master

commit 658b175beff723f8e2a0a38da3ef4e7979f92539
Author: Brant Knudson <email address hidden>
Date: Wed Dec 3 18:47:26 2014 -0600

    Correct test_auth_unscoped_token_project for result ordering

    The order of the roles in the authenticate result will vary depending
    on how a query returns results, so the target role may not be the
    first one. This can be seen by setting the PYTHONHASHSEED value
    to something other than 0.

    With this fix, a search is done rather than checking only the first
    element so that the test works even when the order of the roles is
    different.

    Change-Id: I9ea13a2a7a242336d3658e6027d305f7371e7654
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138920
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=649b4e168220ad1709afd387ee2abfb004c704d8
Submitter: Jenkins
Branch: master

commit 649b4e168220ad1709afd387ee2abfb004c704d8
Author: Brant Knudson <email address hidden>
Date: Wed Dec 3 18:51:50 2014 -0600

    Correct test_get_v3_catalog test for result ordering

    The order of the endpoints and interfaces lists will vary depending on
    how a query returns results, so the endpoints and interfaces may not
    be in the same order as the expected dict. This can be seen by setting
    the PYTHONHASHSEED value to something other than 0.

    With this fix, searches are done rather than using the built-in dict
    equal method.

    Change-Id: I4623401e93c4dd2e9347eb485dc701891af79a44
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138921
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7388d92115b91ca649fc802a138e39205a5f028b
Submitter: Jenkins
Branch: master

commit 7388d92115b91ca649fc802a138e39205a5f028b
Author: Brant Knudson <email address hidden>
Date: Wed Dec 3 18:55:23 2014 -0600

    Correct catalog response checker for result ordering

    The order of the catalog links list will vary depending on how a query
    returns results and the order of the keys returned by keys() may also
    vary. This can be seen by setting the PYTHONHASHSEED value to
    something other than 0.

    With this fix, the links and response keys are compared using a set
    equals so the order doesn't matter.

    Change-Id: If4a606ce45425c5fa51c6e76bf9172cccaf7a427
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138922
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=cd807d0a52f8a5eab19ac3adf795b8e1613f1cbd
Submitter: Jenkins
Branch: master

commit cd807d0a52f8a5eab19ac3adf795b8e1613f1cbd
Author: Brant Knudson <email address hidden>
Date: Wed Dec 3 18:59:20 2014 -0600

    Correct a v3 auth test for result ordering

    The attribute picked by this test may not be one that causes an
    Unauthorized exception to be raised since the order of attributes in
    the list is random. This can be seen by setting the PYTHONHASHSEED
    value to something other than 0.

    With this fix, all the attributes are tested so the order doesn't
    matter and the test coverage is improved.

    Change-Id: I61f9efc5c60271c7ddf75eb4f4eedc66f6f4d67f
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138923
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d76b997acdd28ee7f148751e11dacc49cc224154
Submitter: Jenkins
Branch: master

commit d76b997acdd28ee7f148751e11dacc49cc224154
Author: Brant Knudson <email address hidden>
Date: Wed Dec 3 19:03:33 2014 -0600

    Correct version tests for result ordering

    The order of elements in the versions response depends on how the dict
    is ordered which may differ. This can be seen by setting the
    PYTHONHASHSEED value to something other than 0.

    With this fix, code is written that compares the version elements so
    that the order as returned doesn't matter.

    Change-Id: I24f7fd2fb5e5fc6518c284ce728d2a84e1549272
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136593
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=43ba76f5f84a49c83e77e7a0333f4e5a934fa5a6
Submitter: Jenkins
Branch: master

commit 43ba76f5f84a49c83e77e7a0333f4e5a934fa5a6
Author: Brant Knudson <email address hidden>
Date: Sat Nov 22 13:14:25 2014 -0600

    Remove test PYTHONHASHSEED setting

    The tests are all corrected to work with any PYTHONHASHSEED, so this
    setting in tox.ini can be removed. This will ensure that new tests
    work with any hash seed.

    Change-Id: Ibb118d9b7ba6984797e3f258e4116542e31f74fb
    Closes-Bug: #1348818

[Davanum Srinivas (DIMS) (dims-v)]

I don't see any reviews for Nova master, resetting from "In progress" to "Confirmed" and removing assignee

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/155414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/155724
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b760c7eaf71c338ffb85b3e0b39d4939a478568d
Submitter: Jenkins
Branch: master

commit b760c7eaf71c338ffb85b3e0b39d4939a478568d
Author: Timofey Durakov <email address hidden>
Date: Fri Feb 13 14:44:11 2015 +0300

    fixed tests to work with random PYTHONHASHSEED

    fixed test in:
     nova/tests/unit/compute/test_compute.py
    previous test implementation based on direct relationship
    between flavor.id and flavor.flavorid, which is not
    guarantied by sqlalchemy migration scripts

    Partial-Bug: #1348818

    Change-Id: I1cb2c23ff59ea8145811eebb2ab88ba8158661f6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160667

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160668

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160669

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160670

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160671

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160672

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160897

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160899

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160667
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2b8523f848740420d9b0d07c7478ef7fe828efcf
Submitter: Jenkins
Branch: master

commit 2b8523f848740420d9b0d07c7478ef7fe828efcf
Author: Timofey Durakov <email address hidden>
Date: Thu Feb 12 20:13:08 2015 +0300

    fixed tests in test_vm_util to work with random PYTHONHASHSEED

    fixed tests in:
        nova/tests/unit/virt/vmwareapi/test_vm_util.py
    to succeed with random PYTHONHASHSEED

    Change-Id: I44f0ce3fd9ed5552801f489a0011521d6c5cf208
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160668
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c1a8578c4b3f85a92d7bd6ae7f584a595b3e7d3f
Submitter: Jenkins
Branch: master

commit c1a8578c4b3f85a92d7bd6ae7f584a595b3e7d3f
Author: Timofey Durakov <email address hidden>
Date: Fri Feb 27 16:02:04 2015 +0300

    PYTHONHASHSEED bug fix in test_utils

    fixed test MetadataToDictTestCase.test_dict_to_metadata
    to work properly with random PYTHONHASHSEED

    Partial-Bug: #1348818

    Change-Id: I25f79de17992311aa4eb9abc50b29e3563d09507

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161135

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/155414
Reason: already merged to master

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161313

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161314

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163352

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163353

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163354

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163355

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163356

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163357

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163358

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163359

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163360

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163361

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163362

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163363

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163364

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163877

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165164

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/161314
Reason: squashed with another commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/163353
Reason: squashed with another commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/163355
Reason: squashed with another commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/163356
Reason: squashed with another commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/163360
Reason: squashed with another commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/163362
Reason: squashed with another commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/163363
Reason: squashed with another commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Timofey Durakov (<email address hidden>) on branch: master
Review: https://review.openstack.org/160670
Reason: Sqashed into another commit

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160669
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c4726e1960d8aec0c837142147d5b960d1114e72
Submitter: Jenkins
Branch: master

commit c4726e1960d8aec0c837142147d5b960d1114e72
Author: Timofey Durakov <email address hidden>
Date: Mon Mar 2 09:56:46 2015 +0300

    libvirt test_cpu_info method fixed random PYTHONHASHSEED compatibility

    changed collection for features from list to set to guarantee
    object equality

    Partial-Bug: #1348818

    Change-Id: I26f49e0a4121e3c1a5543f276920433b355de7bf

[Eric Harney (eharney)]

Setting PYTHONHASHSEED=33 for Cinder master @ 8d814b065 shows 35 test failures.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165906

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165906
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2c50eadb822953c0d945dfd6e922dcdede7ab2ce
Submitter: Jenkins
Branch: master

commit 2c50eadb822953c0d945dfd6e922dcdede7ab2ce
Author: Eric Harney <email address hidden>
Date: Thu Mar 19 12:27:59 2015 -0400

    Tests: Fix az test failure when PYTHONHASHSEED != 0

    The test_list_availability_zones_enabled_service test calls
    a method which returns a tuple that is generated from a dict.
    This is compared to a tuple in the test, which can fail when
    PYTHONHASHSEED is not 0, due to the tuples containing elements
    in different orders. (Because the dict used to build the tuple
    was ordered differently.)

    For this test, we can convert to lists and sort them to do the
    comparison, since the ordering is not important.

    Partial-Bug: #1348818

    Change-Id: Ib7e5d59073e5e243450e28492d68942f6088bb5f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165164
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bb6a7bda2ab9ff98a645af24898fa9bd3b2d2519
Submitter: Jenkins
Branch: master

commit bb6a7bda2ab9ff98a645af24898fa9bd3b2d2519
Author: Timofey Durakov <email address hidden>
Date: Mon Mar 2 13:15:17 2015 +0300

    Fixed test to work with random PYTHONHASHSEED

    to compare objects, that contains nested collections new method
    assertJsonEqual was used. Its usage allows not to rely on constant
    order of nested collections elements.

    new method
    assertJsonEqual was used
    Partial-Bug: #1348818

    Change-Id: I0857d3793fb7fca7c5fde3b87dc187088cf965ac

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160671
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cafd381e5d19e445ac6609e0a631a9d3828952e4
Submitter: Jenkins
Branch: master

commit cafd381e5d19e445ac6609e0a631a9d3828952e4
Author: Timofey Durakov <email address hidden>
Date: Mon Mar 2 14:44:36 2015 +0300

    fixed test in test_disk_config to work with random PYTHONHASHSEED

    added deserialization of json to compare them as objects.

    Partial-Bug: #1348818

    Change-Id: I82c59ca9277a2ee0b4a86650f2ab0854bbe3b37f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/168077

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160672
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fe9fc3d3d88dd9361e3973c2137f75885697515e
Submitter: Jenkins
Branch: master

commit fe9fc3d3d88dd9361e3973c2137f75885697515e
Author: Timofey Durakov <email address hidden>
Date: Mon Mar 2 16:57:57 2015 +0300

    Refactored test_availability_zone to work properly with random PYTHONHASHSEED

    Method test_availability_zone_detail refactored, changed implementation for
    zones comparison

    Partial-Bug: #1348818

    Change-Id: Ic4a14aa296bf6bb3f62ea73a23bc42ad19617651

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160897
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=26fb7625dd31bc3ed0bc83288540372df6c7158b
Submitter: Jenkins
Branch: master

commit 26fb7625dd31bc3ed0bc83288540372df6c7158b
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 3 12:28:33 2015 +0300

    fixed tests in test_simple_tenant_usage to pass with random PYTHONHASHSEED

    refactored fake implementation of instance_get_active_by_window_joined.
    if project_id is not None current version generates instances only with
    passed project id

    Partial-Bug: #1348818

    Change-Id: I0fcb61ba6b9ff8a4f0075333048adba66d1c8811

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160898
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=eafa17d0c097e3a04a3a8b1d6518021824220ea3
Submitter: Jenkins
Branch: master

commit eafa17d0c097e3a04a3a8b1d6518021824220ea3
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 3 12:47:17 2015 +0300

    refactored tests in test_wsgi to pass with random PYTHONHASHSEED

    assertions compare parsed response so element order message/code
    became not important

    Partial-Bug: #1348818

    Change-Id: I0be46d38851f4532a0d0738fc1c93d56faa22052

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160899
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3d7f3d16998ade467c0b3648acb2053914161d23
Submitter: Jenkins
Branch: master

commit 3d7f3d16998ade467c0b3648acb2053914161d23
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 3 13:48:02 2015 +0300

    Refactored test in linux_net to pass with random PYTHONHASHSEED

    Previous implementation wraps dns list into set.
    With random PYTHONHASHSEED set elements iteration order
    wasn't guaranteed.

    Partial-Bug: #1348818

    Change-Id: Iffdaf7d75ef2131c9d9fc7aa075c95b5569902c2

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160900
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=40faea05a80551b211f47df291d824219de6a4a4
Submitter: Jenkins
Branch: master

commit 40faea05a80551b211f47df291d824219de6a4a4
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 3 16:06:08 2015 +0300

    fixed tests in test_neutrounv2 to pass with random PYTHONHASHSEED

    to work properly with random python PYTHONHASHSEED fixed
    _deallocate_for_instance method - used set to store port
    for deletion, as had done in deallocate_for_instance
    neutronapi.API class
    test_validate_networks_ex_2 - in except section,
    checked separately that both networks are in
    exception message, as order of networks couldn't
    be predicted

    Partial-Bug: #1348818

    Change-Id: If38850486f8cb84ce0cb739de257027fc52ce692

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160901
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=738e572c42152ed6be127cdca674e8aa373519dd
Submitter: Jenkins
Branch: master

commit 738e572c42152ed6be127cdca674e8aa373519dd
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 3 18:55:52 2015 +0300

    Refactored test in test_neutron_driver to pass with random PYTHONHASHSEED

    Changed argument comparison in mox.Stub from concrete list
    to mox.SameElementsAs.

    Partial-Bug: #1348818

    Change-Id: Id80632ea1c32910d751901c19c98ee76b52eda55

[OpenStack Infra (hudson-openstack)]

Change abandoned by Chris Dent (<email address hidden>) on branch: master
Review: https://review.openstack.org/120823
Reason: abandoned in favor of Change-Id: If93ec7934ad59515b821f056ca534d3676ee7e03

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168077
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=823e1992b410f39a8d1a820509cb1d464e40a0ee
Submitter: Jenkins
Branch: master

commit 823e1992b410f39a8d1a820509cb1d464e40a0ee
Author: Chris Dent <email address hidden>
Date: Thu Mar 26 16:58:09 2015 +0000

    Stop using PYTHONHASHSEED=0 in ceilometer tests

    Otherwise we have tests that rely on ordering (for example the one
    fixed in this patchset).

    Note that this moves the hash seed setting to only be used in docs
    and venv tox targets. For some reason there is an issue in the tooling
    used by the docs build that tickles a bug in those tools. Tools which
    are not part of Ceilometer. To avoid tickling the problem and to move
    ceilometer along on this bug, we're just going to mask that.

    The venv target is used by the jenkins job that builds docs. It runs
    the same build_sphinx setup.py target that the docs target does.

    Change-Id: If93ec7934ad59515b821f056ca534d3676ee7e03
    Closes-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169060

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169060
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5bb63eb0874ab642866c3805ce7b10b0149d65eb
Submitter: Jenkins
Branch: master

commit 5bb63eb0874ab642866c3805ce7b10b0149d65eb
Author: Eric Harney <email address hidden>
Date: Mon Mar 30 15:45:39 2015 -0400

    Tests: Fix v6000 test failure with random hash seed

    If PYTHONHASHSEED is set to a non-zero value, this test
    will fail due to a dependency on dict ordering.

    Rework the test to handle randomly ordered dictionaries.

    Partial-Bug: #1348818

    Change-Id: I92e780db5805e59ac9eef98a07cfbb7a4be54110

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/174356

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161135
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=78883fa459be5151046342593b3e419075e90e36
Submitter: Jenkins
Branch: master

commit 78883fa459be5151046342593b3e419075e90e36
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 10 15:41:17 2015 +0300

    fixed tests in test_instance to pass with random PYTHONHASHSEED

    order of elements in nova_object.changes field could be changed
    from run to run. Sort elements in this field
    Partial-Bug: #1348818
    Change-Id: I7dc450474c499488b535c202eec47ffd1809fc8e

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161313
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5bfe303d11ca05652261a6301c33316c7875feaf
Submitter: Jenkins
Branch: master

commit 5bfe303d11ca05652261a6301c33316c7875feaf
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 10 15:42:15 2015 +0300

    refactored tests in test_objects to pass with random PYTHONHASHSEED

    sort 'nova_object.changes' before comparing
    changed impleplementation of object's fingerprint generator
    Partial-Bug: #1348818
    Change-Id: I43ee58e387ec9d55cd253788295081bf446d6fd9

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163352
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0e28a5f6d4c3c343d8ed961a75f5004c8bccdcb2
Submitter: Jenkins
Branch: master

commit 0e28a5f6d4c3c343d8ed961a75f5004c8bccdcb2
Author: Timofey Durakov <email address hidden>
Date: Thu Mar 5 12:19:08 2015 +0300

    fixed tests in test_iptables_network to work with random PYTHONHASHSEED

    sort chains in _modify_rules metho before usage
    Partial-Bug: #1348818

    Change-Id: I742236b2511ebac36451de161d873798d6f2ef2a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163354
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=56f355ef364b287c5fafb3a91a07ce9adc57f4e0
Submitter: Jenkins
Branch: master

commit 56f355ef364b287c5fafb3a91a07ce9adc57f4e0
Author: Timofey Durakov <email address hidden>
Date: Thu Mar 5 15:02:10 2015 +0300

    refactored tests to pass in test_inject to pass with random PYTHONHASHSEED

    use OrderedDict for metadata to guarantee metadata iteration order
    Partial-Bug: #1348818

    Change-Id: Ifbe2eb94ac27c778c7a53ec95324c429053a9003

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163357
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=63706a80932059670c8557d019b07a77e456d704
Submitter: Jenkins
Branch: master

commit 63706a80932059670c8557d019b07a77e456d704
Author: Timofey Durakov <email address hidden>
Date: Thu Mar 5 19:24:50 2015 +0300

    fix for vmware test_driver_api to pass with random PYTHONHASHSEED

    fix fake.FakeVim._search_ds, incorrect lstrip usage

    Partial-Bug: #1348818

    Change-Id: Iae75bbac678d997ff05ffec15aaffcaed6da5186

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163358
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3e492d78665c26078eacde7686ebad17a91ee4b5
Submitter: Jenkins
Branch: master

commit 3e492d78665c26078eacde7686ebad17a91ee4b5
Author: Timofey Durakov <email address hidden>
Date: Fri Mar 6 11:21:35 2015 +0300

    fixed tests in test_matchers to pass with random PYTHONHASHSEED

    changed order in dicts, build expected string in runtime.
    Partial-Bug: #1348818

    Change-Id: Ia3c5dce2da50135a83121557eb677e9748c34443

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163359
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=80a63292cdb05d53720676fcf4fcccbbf3bbec7a
Submitter: Jenkins
Branch: master

commit 80a63292cdb05d53720676fcf4fcccbbf3bbec7a
Author: Timofey Durakov <email address hidden>
Date: Fri Mar 6 11:49:36 2015 +0300

    refactored test in vmware test_read_write_util to pass with random PYTHONHASHSEED

    changed request url param generation to respect param order before assertion
    Partial-Bug: #1348818

    Change-Id: Ia5f732110dd850e270a33bc5e6640164b2a53e74

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163361
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a37dc549311bb904d111141d75fc30aba03c7f73
Submitter: Jenkins
Branch: master

commit a37dc549311bb904d111141d75fc30aba03c7f73
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 10 11:22:44 2015 +0300

    Refactored tests in test_neutron_driver to pass with random PYTHONHASHSEED

    Use mox.SameElementsAs method for arguments comparison
    Partial-Bug: #1348818

    Change-Id: I18f7f644e455a17be3302ab673247cc83e811774

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163364
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2105f57eeb28534ce292f51a61e283581b426290
Submitter: Jenkins
Branch: master

commit 2105f57eeb28534ce292f51a61e283581b426290
Author: Timofey Durakov <email address hidden>
Date: Tue Mar 10 16:24:50 2015 +0300

    Fixed tests in test_glance to pass with random PYTHONHASHSEED

    Removed ambiguous assertion
    Partial-Bug: #1348818

    Change-Id: I34457b97f44bbc1a58099f986e03b47447662a56

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/174356
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0f2cdcc63ca85bf54b7520e0c87f5d3ce577dfb2
Submitter: Jenkins
Branch: master

commit 0f2cdcc63ca85bf54b7520e0c87f5d3ce577dfb2
Author: Timofey Durakov <email address hidden>
Date: Thu Apr 16 15:36:21 2015 +0300

    Fixed test in test_tracker to work with random PYTHONHASHSEED

    To compare properly objects, field containing json string,
    was replaced to dict, by deserializing json.

    Change-Id: If57a7aaa9d08abbdd12a6e17418701490a813b64
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178190

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178191

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178190
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=36b5dda315879777b223bd3d0270817ae4264c20
Submitter: Jenkins
Branch: master

commit 36b5dda315879777b223bd3d0270817ae4264c20
Author: Timofey Durakov <email address hidden>
Date: Tue Apr 28 13:41:42 2015 +0300

    Fixed functional in tests_servers, to pass with random PYTHONHASHSEED

    In tests/unit/image/fake.py get_valid_image_id returned random
    image_id. This cause test assertion fails, as not all images,
    that stored in fake has 'auto_disk_config': 'True'

    Partial-Bug: #1348818

    Change-Id: I900d6501bc57a23dc703bcfeef311e9c7707d584

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178191
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=69e922d4d72afe82659919beff82f7d77c383c26
Submitter: Jenkins
Branch: master

commit 69e922d4d72afe82659919beff82f7d77c383c26
Author: Timofey Durakov <email address hidden>
Date: Tue Apr 28 16:12:56 2015 +0300

    Changed logic in _compare_result api_samples_test_base

    json responses, could contain fields which values are
    serialized json strings. to properly compare such embedded
    jsons in _compare_result, added extra attempt to deserialize
    string before comparison

    Partial-Bug: #1348818

    Change-Id: Ife379af619a9f1cf571aca3b1a09a7f453cef146

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163877
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7fc0dc05684a10b205212e6e96d9e0298b91c73a
Submitter: Jenkins
Branch: master

commit 7fc0dc05684a10b205212e6e96d9e0298b91c73a
Author: Timofey Durakov <email address hidden>
Date: Thu Mar 12 18:36:19 2015 +0300

    Removed 'PYTHONHASHSEED=0' from tox.ini

    As all bugs, related with that random
    PYTHONHASHSEED fixed, final patch removes that
    from tox.ini

    Change-Id: Ice3920d1290bef46805842734d5bc1e381baf5ec
    Closes-Bug: #1348818

[Stéphane Bisinger (kjir)]

Python 3.4 tests were enabled in WSME and there is no problem with the random PYTHONHASHSEED value.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/185572

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185592

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185633

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185592
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a1d679678daa560c86bb84303aee6163296ec653
Submitter: Jenkins
Branch: master

commit a1d679678daa560c86bb84303aee6163296ec653
Author: Cedric Brandily <email address hidden>
Date: Tue May 26 13:14:11 2015 +0000

    Force order of dhcp.needs_resync_reasons dictionary elements

    This fixes the test_periodoc_resync_helper unit test that breaks with
    a randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the dhcp.needs_resync_reasons dictionary from
    neutron.agent.dhcp.agent had elements in a particular order. Found with
    PYTHONHASHSEED=2.

    The fix refactors the test case to force a sorted dhcp.needs_resync_reasons
    dictionary.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: Ia7fc2c3e605d92d8497d44e28054bdda613cebf2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185735

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185763

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/185858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185763
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=539738a8eeebcc9f22987fcb0a241c6b8c3d561a
Submitter: Jenkins
Branch: master

commit 539738a8eeebcc9f22987fcb0a241c6b8c3d561a
Author: Cedric Brandily <email address hidden>
Date: Wed May 27 00:23:09 2015 +0200

    Do not assume order of get_sync_data_metering response elements

    This fixes the test_add_metering_label_rpc_call[1] unit tests that breaks
    with a randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the get_sync_data_metering[2] had response
    elements in a particular order. Found with PYTHONHASHSEED=1.

    The fix refactors the test_add_metering_label_rpc_call test case to handle
    an unsorted get_sync_data_metering response. The fix defines the class
    UnorderedList[3] which is equal to any permutation of itself.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    [1] neutron.tests.unit.services.metering.test_metering_plugin:
     TestMeteringPluginL3AgentScheduler
     TestMeteringPluginL3AgentSchedulerServicePlugin
    [2] neutron.services.metering.metering_plugin.MeteringPlugin
    [3] neutron.tests.tools

    Change-Id: I5d42b827bc72dcacd38eaa2377ce16c47a9e7dbb

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185970

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185735
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e9d17b8bfff31072a3d017ce64e36ac99007a052
Submitter: Jenkins
Branch: master

commit e9d17b8bfff31072a3d017ce64e36ac99007a052
Author: Cedric Brandily <email address hidden>
Date: Tue May 26 19:54:22 2015 +0200

    Do not assume order of iptables_firewall method responses

    This fixes the iptables_firewall group unit tests[1] that breaks with
    a randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the _get_remote_sg_ids and
    _determine_remote_sgs_to_remove methods from
    neutron.agent.linux.iptables_firewall returned elements in a particular
    order. Found with PYTHONHASHSEED=1.

    The fix refactors the test case to handle unsorted responses from
    _get_remote_sg_ids and _determine_remote_sgs_to_remove.

    [1] neutron.tests.unit.agent.linux.test_iptables_firewall:
     test_prepare_port_filter_with_new_members
     test_prepare_port_filter_with_sg_no_member
     test_remove_port_filter_with_destroy_ipset_chain

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I19e51452a2bde0721559df746047239f68614336

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185970
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ce957ac83a85a421f2e60cc39a3103291ba95e4a
Submitter: Jenkins
Branch: master

commit ce957ac83a85a421f2e60cc39a3103291ba95e4a
Author: Cedric Brandily <email address hidden>
Date: Wed May 27 14:54:35 2015 +0200

    Do not assume order of convert_kvp_list_to_dict method responses

    This fixes the test_attributes unit tests[1] that breaks with a
    randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the convert_kvp_list_to_dict method from
    neutron.api.v2.attributes returned elements in a particular
    order. Found with PYTHONHASHSEED=1.

    The fix refactors the test case to handle unsorted responses from
    convert_kvp_list_to_dict.

    [1] neutron.tests.unit.api.v2.test_attributes.TestConvertKvp

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I864904db1428b88c482ad17a69b33e876a8d042c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/186106

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/186122

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/186106
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e135bcea472e08347fc3dc3df01aa1fa909504fb
Submitter: Jenkins
Branch: master

commit e135bcea472e08347fc3dc3df01aa1fa909504fb
Author: Cedric Brandily <email address hidden>
Date: Wed May 27 19:57:04 2015 +0200

    Do not assume order of dictionary elements in init_l3

    This fixes the test_interface unit tests[1] that breaks with a
    randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the init_l3 method from
    neutron.agent.linux.interface had dictionary elements in a particular
    order. Found with PYTHONHASHSEED=2.

    The fix refactors the test case to handle unsorted dictionaries in
    init_l3.

    [1] neutron.tests.unit.agent.linux.test_interface.TestABCDriver

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I1948593b4d7a0069ef060512942b548c74a6b369

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/186301

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/186301
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b4363a48214f1bb21bd7934f05a6440bb5d66bb7
Submitter: Jenkins
Branch: master

commit b4363a48214f1bb21bd7934f05a6440bb5d66bb7
Author: Cedric Brandily <email address hidden>
Date: Thu May 28 09:07:23 2015 +0200

    Fix PYTHONHASHSEED bugs in test_security_groups_rpc

    This fixes the test_security_group_member/rule_updated unit tests[1]
    that breaks with a randomized PYTHONHASHSEED (see the bug report).

    The test assumed that several dictionaries had elements in a
    particular order. Found with PYTHONHASHSEED=2.

    The fix refactors the test case by injecting values using the same
    ordering[2].

    [1] neutron.tests.unit.agent.test_securitygroups_rpc.\
       TestSecurityGroupAgentWithOVSIptables

    [2] https://github.com/openstack/neutron/blob/\
       e8364a72e62d83e5a76bec1d7aa76ecfe2ed53ac/\
       neutron/tests/unit/agent/test_securitygroups_rpc.py#L1630-L1635

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I5077764045a34d1be0e85bb4b80f3655e87692cc

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/186122
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=36a1d14b58028d0294e67786129a2a09ce393cde
Submitter: Jenkins
Branch: master

commit 36a1d14b58028d0294e67786129a2a09ce393cde
Author: Cedric Brandily <email address hidden>
Date: Wed May 27 20:30:28 2015 +0200

    Do not assume order of security group rules

    This fixes the unit tests[1] that breaks with a randomized
    PYTHONHASHSEED (see the bug report).

    The test assumed that the security_group_rules_for_devices method from
    neutron.agent.securitygroups_rpc returned security group rules in a
    particular order. Found with PYTHONHASHSEED=2.

    The fix refactors the test case to handle unsorted security group rules.

    [1] neutron.tests.unit.plugins.ml2.test_security_group.\
        TestMl2SGServerRpcCallBack.\
        test_security_group_rules_for_devices_ipv4_ingress_addr_pair

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I1b2bd4100c19004f12822c414aefc86aae9849db

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185633
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77303fbeaa060bcee2befad65dccb457fbb6ab65
Submitter: Jenkins
Branch: master

commit 77303fbeaa060bcee2befad65dccb457fbb6ab65
Author: Cedric Brandily <email address hidden>
Date: Tue May 26 14:38:26 2015 +0000

    Sort _get_new/deleted_set_ips responses in unittests

    This fixes the test_set_members_adding/deleting_less_than_5 unit test
    that breaks with a randomized PYTHONHASHSEED (see the bug report).

    The test assumed that the _get_new/deleted_set_ips from
    neutron.agent.linux.ipset_manager return elements in a particular order.
    Found with PYTHONHASHSEED=1.

    The fix refactors the test case to force sorted responses from
    _get_new/deleted_set_ips during unittests.

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I8408365825ec1e97a83c2181f38ec1f9468df91e

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185858
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9ff8cd524621daf6cd20da939238eee14b5a231f
Submitter: Jenkins
Branch: master

commit 9ff8cd524621daf6cd20da939238eee14b5a231f
Author: Cedric Brandily <email address hidden>
Date: Wed May 27 08:53:00 2015 +0200

    Improve test_set_members_deleting_less_than_5

    In test_set_members_deleting_less_than_5[1], 3 ips are deleted from
    ipset but test_set_members_deleting_less_than_5 checked that the
    first one was deleted because the call ordering was non-trivial.

    The test was successful because
    assert_has_calls(expected_calls, any_order=False) allows extra calls
    before and after expected_calls.

    A parent change[2] forces the call ordering, this allows to check that
    the 3 ips are deleted.

    [1] neutron.tests.unit.agent.linux.test_ipset_manager
    [2] I8408365825ec1e97a83c2181f38ec1f9468df91e

    Related-Bug: #1348818

    Change-Id: I773e2cd19fdec634b728d0c3a78c1d66392c743f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185572
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ef5b4f52749b246d8165058ff320399c9c13f5ac
Submitter: Jenkins
Branch: master

commit ef5b4f52749b246d8165058ff320399c9c13f5ac
Author: Cedric Brandily <email address hidden>
Date: Tue May 26 14:29:15 2015 +0200

    Enable random hash seeds

    Neutron tests have been updated in order to support random hash seed. It
    allows to remove PYTHONHASHSEED=0 in tox.ini and remove hashtest tox
    environment.

    Closes-Bug: #1348818
    Change-Id: I1063304dda887eb82c0de8516d5a483fa8943fc1
    Depends-On: I8408365825ec1e97a83c2181f38ec1f9468df91e
    Depends-On: I1b2bd4100c19004f12822c414aefc86aae9849db
    Depends-On: I5077764045a34d1be0e85bb4b80f3655e87692cc

[Cedric Brandily (cbrandily)]

neutron-*aas have to be fixed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/187106

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/187107

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/187230

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/187231

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/187292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/187293

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187106
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=40c004f9877dd47673c849a0e81dc7aff52c4d7c
Submitter: Jenkins
Branch: master

commit 40c004f9877dd47673c849a0e81dc7aff52c4d7c
Author: Cedric Brandily <email address hidden>
Date: Sun May 31 21:56:43 2015 +0200

    Do not assume order of mounts in execute_with_mount

    This fixes the unit tests[1] that breaks with a randomized
    PYTHONHASHSEED (see the bug report).

    The test assumed that the execute_with_mount method[2] performs
    filesystem mounts in a particular order. Found with PYTHONHASHSEED=1.

    The fix refactors the test case to handle unsorted mounts.

    [1] neutron_vpnaas.tests.unit.services.vpn.common.test_netns_wrapper.\
        TestNetnsWrapper.test_netns_wrap
    [2] neutron_vpnaas.services.vpn.common.netns_wrapper

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I164c477f32c6781e9974d4d13a4f91a15b99201c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187292
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=52d40851418db73cde4d9459637de69797ba2bd4
Submitter: Jenkins
Branch: master

commit 52d40851418db73cde4d9459637de69797ba2bd4
Author: Cedric Brandily <email address hidden>
Date: Mon Jun 1 21:06:46 2015 +0200

    Do not assume http expected_codes ordering

    This fixes the unit tests[1] that breaks with a randomized
    PYTHONHASHSEED (see the bug report).

    The test assumed that expected_codes had elements in particular order.
    Found with PYTHONHASHSEED=1.

    The fix refactors the test case by injecting values using the same
    ordering.

    [1] neutron_lbaas.tests.unit.services.loadbalancer.drivers.haproxy.\
        test_jinja_cfg

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I5d761c392bf37a0b3626abc64e0e428f978638df

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187107
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=363c45713474c9f27e02132c3ab3492b67cb0852
Submitter: Jenkins
Branch: master

commit 363c45713474c9f27e02132c3ab3492b67cb0852
Author: Cedric Brandily <email address hidden>
Date: Mon Jun 1 07:53:41 2015 +0200

    Enable random hash seeds

    neutron-vpnaas tests have been updated in order to support random hash
    seed. It allows to remove PYTHONHASHSEED=0 in tox.ini and remove
    hashtest tox environment.

    Change-Id: I94c160c56d074c7a14aaae1fff379fc1c51bd16a
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187230
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=0660c0518ebc349fa678ddcb56255577ff7d57cc
Submitter: Jenkins
Branch: master

commit 0660c0518ebc349fa678ddcb56255577ff7d57cc
Author: Cedric Brandily <email address hidden>
Date: Mon Jun 1 15:19:59 2015 +0000

    Do not assume jsonutils.dumps ordering

    This fixes the unit tests[1] that breaks with a randomized
    PYTHONHASHSEED (see the bug report).

    The test assumed that the oslo_serializarion.jsonutils.dumps performs
    dictionary json dump in particular order. Found with PYTHONHASHSEED=1.

    The fix refactors the test case by disabling json dumps and comparing
    dictionnaries instead of their json dumps.

    [1] neutron_fwaas.tests.unit.services.firewall.drivers.mcafee.\
        test_ngfw_fwaas:
      NGFWFwaasTestCase.test_create_firewall
      NGFWFwaasTestCase.test_update_firewall

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I67fe1ab69bcfd99c2e778963b97c0d6b4b039802

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187231
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=e91970f370868b3c157d9ea6ec522a566e96d218
Submitter: Jenkins
Branch: master

commit e91970f370868b3c157d9ea6ec522a566e96d218
Author: Cedric Brandily <email address hidden>
Date: Mon Jun 1 15:20:48 2015 +0000

    Enable random hash seeds

    neutron-fwaas tests have been updated in order to support random hash
    seed. It allows to remove PYTHONHASHSEED=0 in tox.ini and remove
    hashtest tox environment.

    Change-Id: I35f89a9ab6883f5fd600be804d75b67275e6629a
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187293
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=b6c8ece12c5f45a688537c5075d01d2668d206d9
Submitter: Jenkins
Branch: master

commit b6c8ece12c5f45a688537c5075d01d2668d206d9
Author: Cedric Brandily <email address hidden>
Date: Mon Jun 1 21:11:22 2015 +0200

    Enable random hash seeds

    neutron-lbaas tests have been updated in order to support random hash
    seed. It allows to remove PYTHONHASHSEED=0 in tox.ini and remove
    hashtest tox environment.

    Closes-Bug: #1348818
    Change-Id: I7dce768feeb7c34cdd67bcd54a253d97f4e88f4e
    Depends-On: I1063304dda887eb82c0de8516d5a483fa8943fc1
    Depends-On: I35f89a9ab6883f5fd600be804d75b67275e6629a
    Depends-On: I94c160c56d074c7a14aaae1fff379fc1c51bd16a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/191567

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/196701

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyle Mestery (<email address hidden>) on branch: feature/pecan
Review: https://review.openstack.org/196701
Reason: This is lacking the functional fix [1], so I'll propose a new merge commit which includes that one.

[1] https://review.openstack.org/#/c/196711/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/196920

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/196920
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7f759c077f8f860c13db92d2ea6b353ef6b70900
Submitter: Jenkins
Branch: feature/pecan

commit 8123144fadd7c5d5e6e56a76ea860512619a2cf6
Author: Moshe Levi <email address hidden>
Date: Sun Jun 28 14:37:14 2015 +0300

    Fix Consolidate sriov agent and driver code

    This patch add mising __init to mech_sriov/mech_driver/
    and update the setup.cfg to the new agent entrypoint

    Trivial Fix

    Change-Id: I53a527081feb78472f496675bbb3c5121d38a14a

commit 8942fccf02e6e179d47582fdb2792a1ca972da21
Author: Assaf Muller <email address hidden>
Date: Mon Jun 29 11:38:51 2015 -0400

    Remove failing SafeFixture tests

    The fixtures 1.3 release attempted to fix the fixtures resource
    leak issue, but failed to do so completely. Our own SafeFixture
    is still needed: The 1.3 release broke our SafeFixture tests,
    but not the usage of SafeFixture itself. This patch removes
    those failing tests for now to unbreak the gate. Jakub reported
    a bug on fixtures 1.3:
    https://bugs.launchpad.net/python-fixtures/+bug/1469759

    We will continue to use SafeFixture until that bug is fixed
    in fixtures, at which point we will be able to require
    fixtures > 1.3.

    Change-Id: I59457c3bb198ff86d5ad55a1e623d008f0034b8f
    Closes-Bug: #1469734

commit 71dffb0a2c1720cd8233a329d32958a0160dd6f5
Author: Kevin Benton <email address hidden>
Date: Mon Jun 29 08:27:41 2015 +0000

    Revert "Removed test_lib module"

    This reverts commit 9a6536de6e1a7fe9b2552adc142e254426b82b6f.

    We pulled all of the plugins out of the tree, many of which still inherit
    from neutron test classes. This change then stated that we no longer
    support testing other plugins. I think this is a bit premature and should
    have been discussed under the subject
    "Neutron plugins can't use neutron plugin unit tests" or something
    similar.

    Change-Id: I68318589f010b731574ea3bfa8df98492bab31fc

commit b20fd81dbd497e058384a0af065dd0f1fdc4c728
Author: Jakub Libosvar <email address hidden>
Date: Fri Jun 5 14:32:51 2015 +0000

    Refactor NetcatTester class

    Following capabilities were added:
       - used transport protocol is passed as a constant instead of bool
       - src port for testing was added
       - connection can be established explicitly
       - change constructor parameters of NetcatTester

    As a part of removing bool for protocol definition
    get_free_namespace_port() was also modified to match the behavior.

    Change-Id: Id2ec322e7f731c05a3754a65411c9a5d8b258126

commit 83e37980dcd0b2bad6d64dd2cb23bcd2891cafca
Author: jingliuqing <email address hidden>
Date: Sat Jun 27 13:41:54 2015 +0800

    Use REST rather than ReST

    Change-Id: I06c9deaab58c5ec13bfeec39fb8fd4b1fe21f42d

commit 1b60df85ba3ad442c2e4e7e52538e1b9a1bf9378
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:34:38 2015 -0700

    Add a double-mock guard to the base test case

    Use mock to patch mock with a check to prevent multiple active
    patches to the...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/214539

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214539
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b070ed0286206fcde36df5e0da39a227e2dfdb38
Submitter: Jenkins
Branch: master

commit b070ed0286206fcde36df5e0da39a227e2dfdb38
Author: Wang Muyu <email address hidden>
Date: Sun Aug 16 11:21:24 2015 -0400

    Improve unit tests to succeed without hash tweak

    PYTHONHASHSEED was set to 0 to disable hash randomization, because some
    tests assertions were order sensitive. This commit is to improve the
    assertions, so the PYTHONHASHSEED hack in tox.ini is not needed.

    Change-Id: I4ff09d202af818d27321e8e83718e82d0c48e3d2
    Closes-Bug: 1348818

[Derrick Wippler (thrawn01)]

Mistakenly Change cinder status from 'In Progress' to 'Fix Released', Unable to revert change.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/191567
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/229991
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2e20e70e1430b1f05a98616ba47464829e764390
Submitter: Jenkins
Branch: master

commit 2e20e70e1430b1f05a98616ba47464829e764390
Author: Victor Stinner <email address hidden>
Date: Thu Oct 1 18:04:30 2015 +0200

    Fix volume throttling to Python 3

    BlkioCgroup._set_limits(): sort devices before iterating on them to
    have a reliable behaviour.

    The devs variable is a dictionary. On Python 3, the hash function is
    now randomized, so iterating on a dictionary gives items in a random
    order. Use sorted() to iterate on the list of sorted devices instead.

    tox.ini: add cinder.tests.unit.test_volume_throttling to Python 3.

    Blueprint cinder-python3
    Partial-Bug: #1348818
    Change-Id: Icf7141f772397c7ac08f0f1e21ad74cb86a06351

[Akihiro Motoki (amotoki)]

We cannot update the status to Fix Released in neutronclient. Instead i will remove neutronclient from the affected projects to make the bug list simple. It was fixed in neutronclient long time ago, so the impact of removing neutronclient from the list would be small.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/267677

[OpenStack Infra (hudson-openstack)]

Change abandoned by Itxaka Serrano Garcia (<email address hidden>) on branch: master
Review: https://review.openstack.org/267677
Reason: This change requires a whole refactor of the projects tests.

The tests failing are some pretty bad ones, where we change names, quotas, roles and members ALL in the same test. Not only that but the order of members is hardcoded heavily and the code is unreadable.

Abandoning this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/272729

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/272736

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/280224

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/280241

[OpenStack Infra (hudson-openstack)]

Change abandoned by Victor Stinner (<email address hidden>) on branch: master
Review: https://review.openstack.org/280224
Reason: tox.ini runs tests with PYTHONHASHSEED=0, so this bug is more "theorical". I prefer to abandon it.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280241
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f0ef5e50e4bda799d870a5694b01eae73a9f1a58
Submitter: Jenkins
Branch: master

commit f0ef5e50e4bda799d870a5694b01eae73a9f1a58
Author: Victor Stinner <email address hidden>
Date: Mon Feb 15 14:43:32 2016 +0100

    Port test_emc_vnx to Python 3

    * Configuration.__getattr__(): replace self.local_conf with
      object.__getattribute__(self, 'local_conf') to avoid reentrant call
      to __getattr__() in copy.copy(conf) on Python 3.
    * test_emc_vnx: Don't compare directly provider_location strings but
      set of provider_location items to support hash randomization. On
      Python 3, hash randomization is enabled by default and so
      dictionary items are rendered in an random order.
    * test_emc_vnx: use assertIn() to check if the provider_location
      contains 'type^smp' substring. Before, the test failed if the
      substring was a the beginning of the string (position 0).
    * tests-py3.txt: add cinder.tests.unit.test_emc_vnx

    Partial-Implements: blueprint cinder-python3
    Related-Bug: 1348818
    Change-Id: If3be17ca6a1d14d6f1a16ee9934221f77e161686

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272729
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ff30c682fb71500272b94d239acac82a2373889a
Submitter: Jenkins
Branch: master

commit ff30c682fb71500272b94d239acac82a2373889a
Author: Itxaka <email address hidden>
Date: Tue Jan 26 21:34:35 2016 +0100

    Use InAnyOrder for role creation mocks

    The user/roles can be created in any order due to
    python random seed ordering dictionaries, so the
    mocks should be in random order

    Change-Id: I23a9380fb65ac634831beb496af388381d0230d4
    Partial-Bug: #1348818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272736
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0c118e43395465387b2c911129ec237efaf7db48
Submitter: Jenkins
Branch: master

commit 0c118e43395465387b2c911129ec237efaf7db48
Author: Itxaka <email address hidden>
Date: Tue Jan 26 21:52:51 2016 +0100

    Remove PYTHONHASHSEED=0 from tox

    Remove PYTHONHASHSEED=0 so the tests run
    with a random seed.

    Change-Id: I681d2b37453642b4823e8341a03d077ebc9cb9a7
    Closes-Bug: #1348818

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465636
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=52965d8974ca62bfaa4201d3057a0b5742e5c818
Submitter: Zuul
Branch: master

commit 52965d8974ca62bfaa4201d3057a0b5742e5c818
Author: Eric Harney <email address hidden>
Date: Wed May 17 11:29:58 2017 -0400

    Enable hash randomization in unit tests

    This is needed to ensure that unit tests match how
    deployed environments run.

    Related-Bug: #1348818
    Related-Bug: #1658725
    Related-Bug: #1715915

    Depends-On: I91a53fdef98c9a14ccc536403063e228e99d6971
    Depends-On: Ie548c90f5657e5270fd966207f453d5211e21867
    Depends-On: I754d48d8bc4081b96fdf90465c4897d0fadd6262
    Depends-On: Ia8762aff6fd9954d350310b4c68ee4fe94de68bf
    Depends-On: I6fe0ae5da270d9c77cb248551dcb32a5c063977a
    Depends-On: I96b9b413387f2ef02ea7ccfb6e676cad0b87c6f1
    Depends-On: Icdde5e3f213adfe4893d1b9e8f2bfe4f61704037
    Depends-On: I29a874ebe0ebaeca58b428faa0bab50482baf6f1
    Depends-On: I30817ae767e08c45f9540b19e922864fe2f7a9c2
    Depends-On: I281ad59fa518f936aa8d1b518acf61800ba949f5
    Depends-On: I0abd0415306c0c0544eb5d9a6ed08640ff6bb0cf
    Depends-On: I599b585444cbd51182d9f17fddd97bd91637e1e3
    Depends-On: I6e4093ca8e79128ed23a4d5068e5d2870e16332c
    Depends-On: I574dca83a971e746a54895a87e394befda0ccdcf
    Depends-On: Id5a961c66a62e289a96daa7437374768ef407bb6
    Depends-On: Ibc6c20e6ffce58c6bbef3155f73e54909d76e132
    Change-Id: I4c7396f9d8e58ac8420754503f8ed60cd7473426