OpenStack Compute (nova)

  1. Bug #1348818
  2. Comment #204

Comment 204 for bug 1348818

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/187106
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=40c004f9877dd47673c849a0e81dc7aff52c4d7c
Submitter: Jenkins
Branch: master

commit 40c004f9877dd47673c849a0e81dc7aff52c4d7c
Author: Cedric Brandily <email address hidden>
Date: Sun May 31 21:56:43 2015 +0200

    Do not assume order of mounts in execute_with_mount

    This fixes the unit tests[1] that breaks with a randomized
    PYTHONHASHSEED (see the bug report).

    The test assumed that the execute_with_mount method[2] performs
    filesystem mounts in a particular order. Found with PYTHONHASHSEED=1.

    The fix refactors the test case to handle unsorted mounts.

    [1] neutron_vpnaas.tests.unit.services.vpn.common.test_netns_wrapper.\
        TestNetnsWrapper.test_netns_wrap
    [2] neutron_vpnaas.services.vpn.common.netns_wrapper

    Partial-bug: #1348818

    Note: There are several other unrelated unit tests that also break with
    a randomized PYTHONHASHSEED, but they are not addressed here. They will
    be addressed in separate patches.

    Change-Id: I164c477f32c6781e9974d4d13a4f91a15b99201c