| 2017-11-16 17:30:37 |
Matt Riedemann |
description |
This change https://review.openstack.org/#/c/184281/ in 2015 (Liberty release, 2.27.0 release of novaclient) broke the SecretsHelper in the shell because it does API version discovery which requires authentication, but if you don't provide a --os-token or --os-password (or their equivalent environment variables), we don't even get to the SecretsHelper code to prompt for a password.
Moving the SecretsHelper code block up before the API version discovery does get you the password prompt, but it appears to still not work properly.
Given how long this has been broken and no one has cared, it seems pointless to fix it at this point, and it's untested, so we should probably just remove it. |
This change https://review.openstack.org/#/c/184281/ in 2015 (Liberty release, 2.27.0 release of novaclient) broke the SecretsHelper in the shell because it does API version discovery which requires authentication, but if you don't provide a --os-token or --os-password (or their equivalent environment variables), we don't even get to the SecretsHelper code to prompt for a password.
Moving the SecretsHelper code block up before the API version discovery does get you the password prompt, but it appears to still not work properly:
http://paste.openstack.org/show/626539/
Given how long this has been broken and no one has cared, it seems pointless to fix it at this point, and it's untested, so we should probably just remove it. |
|
