Comment 5 for bug 1323996
Revision history for this message
| jichenjc (jichenjc) wrote Re: resize fail didn't should a correct info when --poll specified when resize down | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
@melanie, thanks for your comments it's not hard to add a state FAILED_RESIZE and I have following concerns
In the report of the bug ,if user want to resize with a smaller disk, it's kind of 'wrong' action, and from nova
perspective, it will do nothing but do some valid check, then nova decide not to do that action
so the instance is not changed at all ,only the 'action' failed but the instance is still ACTIVE
so we can take this defect into 2 steps , first is to notify user the 'resize' failed instead of silent
then we can consider whether we need to add FAILED_RESIZE feature since we might need a lot of other codes to handle this kind of state, e.g. in _init_instance, and I know we are going to have a 'task' state which will report those kind of failure instead of setting to ERROR state, maybe it will handle this better
thoughts? thanks a lot