Comment 3 for bug 1193049

Loic Dachary (dachary) wrote :

The original review had no discussion https://review.openstack.org/#/c/4945/ and from the comment in https://review.openstack.org/#/c/4945/3/novaclient/utils.py,unified it looks like the slugify function was copy pasted from http://code.activestate.com/recipes/577257-slugify-make-a-string-usable-in-a-url-or-filename/ which has a different focus : it is meant to create a valid path name from a string.

The human readable id for bash completion must not be transformed in any way because it will just make it an invalid id.

The call to the slugify function should just be removed when adding a value to the bash completion cache and that will resolve the problem.

The problem related to spaces in names should be addressed as a separate bug, I think. Although it is related, it is a different kind of problem.