Comment 1 for bug 921355

Revision history for this message
Andreas Roehler (a-roehler) wrote : Re: [Bug 921355] [NEW] python.el sources need to be re-indented

Am 25.01.2012 02:44, schrieb François Pinard:
> Public bug reported:
>
> Hi, people. My first formal report pertaining to python-mode.el :-)

Hi François,

think everyone here will know what you have done for Emacs. Really
feeling honored ;)

>
> Trying to read bits of python-mode.el sources, I stumbled on wrongly
> indented lines. Which is fairly surprising, as Emacs is especially
> helpful at staying clean in this area. After having met a few places
> where this clearly impacts on legibility, I decided to report it.
>
> Doing `C-x h TAB' repairs it all, easily.

thanks for the hint

   Here, this modifies 442 lines
> on a total of 9181 lines, for python-mode.el only.
>
> I did not check the other .el files, but I suggest they all get revised
> in the same way. Indentation should be perfect, always. :-)

completely agree. Use a function here, which when a function gets
formatted re-formats the whole buffer. Maybe should bind it onto some
later occasion, prepend it before compile?

changed my ediff-options, removed "-w" and "-i"

>
> François
>
> P.S. This is for whitespace on the left side of lines.

Might some XEmacs provisions have delivered that impression?

python-mode is
> almost perfect on the right side of lines, there is not much spurious
> trailing whitespace in this package. Amusingly, the worst file is doc
> /commands-python-mode.el, which is likely generated automatically. The
> generator should be corrected for not doing this.

Probably. Never looked into, as it's generated and used by a program
only. As for internal use only, will remove it from the repo.

thanks again!

Andreas