Comment 17 for bug 1107037

Revision history for this message
Andreas Roehler (a-roehler) wrote : Re: [Bug 1107037] Re: python-mode very slow

Am 02.02.2013 12:27, schrieb Tom Willemsen:
> Andreas Roehler <email address hidden> writes:
>
>> IMHO it's not fixed that way, maybe just working per chance because of
>> (bobp)
>
> It shouldn't, it's one of the possibilities, docstrings appear either at
> the start of a function/method, the start of a class or the start of a
> module (file). So after going to the beginning of the statement it
> should just be at either at the start of def-or-class or at the
> beginning of the file.
>

right. I'm correcting my previous post in such: check for (or looking-at ... (bopb)) is needed.

> If there is something wrong with my reasoning please let me know.
>
>> Severals errors inside.
>
> Inside what? If they're in my code please let me know and I will try to
> fix it.
>

it relats to the (beginning-of-def-or-class) call now, which is wrong IMHO as might reach BOB
  while just called from inside a string, needed is beginning-of-statement.

>> Patch attached should fix it against previous commit.
>
> The patch broke all python font locking for me.
>

Ohh, indeed.

So I'm awaiting your next post/commit :-)