| 2020-10-11 07:49:46 |
Maari Tamm |
description |
The OpenStack Client comes with a set of helpful output formatting arguments,
which include '-c COLUMN', '--column COLUMN'.
However, two of our commands have been implemented with an additional '--columns'
argument, which also happens to be breaking the usage for '-c /--column':
1) The 'share type list' command [1][2]
$ openstack share type list -c id
'list' object has no attribute 'split'
2) The 'share access list' command [3][4]
$ openstack share access list myshare -c id
'list' object has no attribute 'split'
We should really be using the '-c /--column' options instead of adding our own additional logic for that.
[1] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_types.py#L395-L400
[2] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_types.py#L423-L432
[3] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_access_rules.py#L167-L173
[4] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_access_rules.py#L225-L237 |
The OpenStack Client comes with a set of helpful output formatting arguments, which include '-c COLUMN', '--column COLUMN'.
However, two of our commands have been implemented with an additional
'--columns' argument, which also happens to be breaking the usage for
'-c /--column':
1) The 'share type list' command [1][2]
$ openstack share type list -c id
'list' object has no attribute 'split'
2) The 'share access list' command [3][4]
$ openstack share access list myshare -c id
'list' object has no attribute 'split'
We should really be using the '-c /--column' options instead of adding our own additional logic for that.
[1] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_types.py#L395-L400
[2] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_types.py#L423-L432
[3] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_access_rules.py#L167-L173
[4] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_access_rules.py#L225-L237 |
|
