OSC "-c / --column" args not working as expected

[Maari Tamm]

The OpenStack Client comes with a set of helpful output formatting arguments, which include '-c COLUMN', '--column COLUMN'.

However, two of our commands have been implemented with an additional
'--columns' argument, which also happens to be breaking the usage for
'-c /--column':

1) The 'share type list' command [1][2]

$ openstack share type list -c id
'list' object has no attribute 'split'

2) The 'share access list' command [3][4]

$ openstack share access list myshare -c id
'list' object has no attribute 'split'

We should really be using the '-c /--column' options instead of adding our own additional logic for that.

[1] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_types.py#L395-L400
[2] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_types.py#L423-L432
[3] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_access_rules.py#L167-L173
[4] https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share_access_rules.py#L225-L237

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/760689

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/760689
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=f98d4fa7d3a78cfdd09b1461597d9034da720e94
Submitter: Zuul
Branch: master

commit f98d4fa7d3a78cfdd09b1461597d9034da720e94
Author: yara <email address hidden>
Date: Sat Oct 31 14:22:58 2020 +0000

    Implements usage of '-c /--column' instead of additional logic.

    "openstack share type list" and "openstack share access list"
    do not need a "--columns" option.
    The OSC client has inherent support for output filtering
    via the "-c/--column" options.

    Closes-Bug:#1899325

    Change-Id: I6666e279e5ec97ced2e03aaf1eb88faec7408531

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 2.4.0 release.