Comment 1 for bug 1811516

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/630462
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=b955ac9064b15d00e8966dda745814c146c8af01
Submitter: Zuul
Branch: master

commit b955ac9064b15d00e8966dda745814c146c8af01
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Jan 16 16:31:21 2019 -0800

    [Python3] Fix python3 bugs in code

    - The BaseException class no longer has a "message"
      attribute in python 3 [1]. On the contrary, the
      string representation of an Exception object will
      print all the exception args in all supported
      python versions, so use that instead.
    - Functional tests were run with a specific locale,
      remove those annotations so we can handle unicode
      encoding and decoding in python3 envs.
    - Cleanup errors were not being handled correctly,
      cleanup the code so we don't have spurious failures.
    - In python3, dict.keys() gives you a view for lazy
      loading, so convert occurrences to lists as expected
      in our functional tests.
    - Start capturing STDOUT and STDERR in tox envs to
      enable troubleshooting.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>
    Closes-Bug: #1811627
    Closes-Bug: #1811516
    Change-Id: Idaa2fb9b60451b3fbd298e19574195f2d663c6f4
    [1] https://www.python.org/dev/peps/pep-0352/#transition-plan