commit 80ec2919ca6dafe458c2db2e455f937e2f67cfe2
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Oct 8 15:09:39 2018 -0700
Stop encoding "~" in query parameters
IETF RFC 3986 classifies "~" as a reserved character [1],
however until python3.7 [2], python's url parsing
used to encode this character.
urllib has seen a lot of churn in various python
releases, and hence we were using a six wrapper
to shield ourselves, however, this backwards-incompatible
change in encoding norms forces us to deal with
the problem at our end.
Manila's API accepts "~" in both, its encoded
or un-encoded forms. So, let's stop encoding it
within manilaclient, regardless of the version
of python running it.
Reviewed: https:/ /review. openstack. org/597181 /git.openstack. org/cgit/ openstack/ python- manilaclient/ commit/ ?id=80ec2919ca6 dafe458c2db2e45 5f937e2f67cfe2
Committed: https:/
Submitter: Zuul
Branch: master
commit 80ec2919ca6dafe 458c2db2e455f93 7e2f67cfe2
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Oct 8 15:09:39 2018 -0700
Stop encoding "~" in query parameters
IETF RFC 3986 classifies "~" as a reserved character [1],
however until python3.7 [2], python's url parsing
used to encode this character.
urllib has seen a lot of churn in various python incompatible
releases, and hence we were using a six wrapper
to shield ourselves, however, this backwards-
change in encoding norms forces us to deal with
the problem at our end.
Manila's API accepts "~" in both, its encoded
or un-encoded forms. So, let's stop encoding it
within manilaclient, regardless of the version
of python running it.
[1] https:/ /tools. ietf.org/ html/rfc3986. html /docs.python. org/3/library/ urllib. parse.html# url-quoting
[2] https:/
Closes-Bug: #1785283 1fa966c8019a52e 9fca19e387e
Change-Id: I6df5d543ae94ed