Comment 22 for bug 1712835

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/848112
Committed: https://opendev.org/openstack/python-manilaclient/commit/7f7d7d32dcabfa619ea9e1717483062026e0b61f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7f7d7d32dcabfa619ea9e1717483062026e0b61f
Author: Eric Harney <email address hidden>
Date: Tue Feb 26 11:41:27 2019 -0500

    Re-enable shell completion cache

    This enables writing ids to a local completion
    cache when using the manilaclient shell, which
    allows tools/manila.bash_completion to complete
    commands such as:
        manila delete a<tab>

    Share ids are recorded on "manila list" operations.

    Caching can be expanded to cover additional
    types of manila objects using this same infrastructure.

    Uses ~/.cache/manilaclient/ to match path standards,
    and uses SHA-1 since Python running w/ FIPS mode may
    not have MD5.

    Also, fix a small bug in the fakes used in our test suite.
    We were adding the shares count (an optional param) to all
    the list responses, while this is something that should be done
    only if the param with_count is set to True.

    Co-Authored-By: Victoria Martinez de la Cruz <email address hidden>
    Closes-Bug: #1712835
    Change-Id: I7f4dedf1dd4b7db6cf24fc1c4ed2a8d3685f714c
    (cherry picked from commit 6ecdbef0fcbdde1f6ea6441bc58efb91422a008e)