Comment 40 for bug 1616105

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (stable/mitaka)

Reviewed: https://review.openstack.org/418197
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=13054e8b6d4e04c19ce24a3c8fcca320333c45fa
Submitter: Jenkins
Branch: stable/mitaka

commit 13054e8b6d4e04c19ce24a3c8fcca320333c45fa
Author: Samuel de Medeiros Queiroz <email address hidden>
Date: Tue Jan 3 11:04:59 2017 -0300

    Only log application/json content type

    This is a combination of 2 commits. The first commit's
    message is:

    Prevent MemoryError when logging response bodies

    Response bodies are loaded into memory prior to
    being logged.

    Loading huge response bodies may result in a
    MemoryError.

    This patch proposes that only JSON and TEXT
    responses be logged, i.e when the Content-Type
    header is application/json or application/text.

    Responses that do not include or have a different
    Content-Type header will have their body omitted.

    Closes-bug: 1616105

    Change-Id: I93b6fff73368c4f58bdebf8566c4948b50980cee
    (cherry picked from commit f345559a06c0128dcb7fede4b593487540da86ef)

    This is the 2nd commit message:

    Only log application/json in session to start

    When whitelisting content types to debug print from session we chose
    application/json and application/text. application/text is not a real
    mime type, text is typically text/plain.

    Rather than guess at mime types only print application/json to start
    with, but make it easy for additional types to be added later.

    Change-Id: Ica5fee076cdab8b1d5167161d28af7313fad9477
    Related-Bug: 1616105
    (cherry-picked from: d73fd3ee8438f760c37d9ef401ebf89a45a59f1d)