Comment 4 for bug 1504197

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (stable/liberty)

Reviewed: https://review.openstack.org/234451
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=cd84edd2bec0e71d9a7f83c6fe1b9ab9b18fcecf
Submitter: Jenkins
Branch: stable/liberty

commit cd84edd2bec0e71d9a7f83c6fe1b9ab9b18fcecf
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 8 17:06:02 2015 +0100

    Mock keystone call to avoid test failure

    The test test_password_prompted() was expecting a keystone failure, but
    because of an error in the requests/urllib3 library it was returning a
    different exception and causing our tests to fail, see[1].

    Independent of the the problem above on tests we should not rely on some
    external library failing like that, we should mock this failures to make
    our tests more reliable and that's what this patch is doing.

    [1] https://bugs.launchpad.net/ospurge/+bug/1503768

    Change-Id: I3e6091eb2bc221a16fdc18b998ba138058818894
    Closes-Bug: #1504197
    (cherry picked from commit 42d52af3c2238900eb69217bba5dbbcdca63abf0)