commit cd84edd2bec0e71d9a7f83c6fe1b9ab9b18fcecf
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 8 17:06:02 2015 +0100
Mock keystone call to avoid test failure
The test test_password_prompted() was expecting a keystone failure, but
because of an error in the requests/urllib3 library it was returning a
different exception and causing our tests to fail, see[1].
Independent of the the problem above on tests we should not rely on some
external library failing like that, we should mock this failures to make
our tests more reliable and that's what this patch is doing.
Reviewed: https:/ /review. openstack. org/234451 /git.openstack. org/cgit/ openstack/ python- ironicclient/ commit/ ?id=cd84edd2bec 0e71d9a7f83c6fe 1b9ab9b18fcecf
Committed: https:/
Submitter: Jenkins
Branch: stable/liberty
commit cd84edd2bec0e71 d9a7f83c6fe1b9a b9b18fcecf
Author: Lucas Alvares Gomes <email address hidden>
Date: Thu Oct 8 17:06:02 2015 +0100
Mock keystone call to avoid test failure
The test test_password_ prompted( ) was expecting a keystone failure, but
because of an error in the requests/urllib3 library it was returning a
different exception and causing our tests to fail, see[1].
Independent of the the problem above on tests we should not rely on some
external library failing like that, we should mock this failures to make
our tests more reliable and that's what this patch is doing.
[1] https:/ /bugs.launchpad .net/ospurge/ +bug/1503768
Change-Id: I3e6091eb2bc221 a16fdc18b998ba1 38058818894 0eb69217bba5dbb cdca63abf0)
Closes-Bug: #1504197
(cherry picked from commit 42d52af3c223890