Wrong usage of parameter `endpoint_override`

[Ekaterina Khomyakova]

https://github.com/openstack/python-heatclient/blob/master/heatclient/common/http.py#L350

Unexpected usage of endpoint_override for OpenStackClient.

[tamil vanan (tamilhce)]

As mentioned

https://github.com/openstack/python-heatclient/blob/master/heatclient/common/http.py#L350

if its causing any issue in heat functionality, share me the steps to reproduce , else we can remove or comment out the "endpoint_override"

[Ekaterina Khomyakova (ekhomyakova)]

https://bugs.launchpad.net/fuel/+bug/1621471
https://review.openstack.org/#/c/367363

heat stack can not be created when we use this:
`HeatClient(session=self.keystone_session, endpoint_override=endpoint)`
now we have to use
`HeatClient(session=self.keystone_session, endpoint=endpoint)`
but it is not the same way, that we use for all others OpenStack clients.

[Aleksei Stepanov (penguinolog)]

In glanceclient working code:

    if session:
        if endpoint:
            kwargs.setdefault('endpoint_override', endpoint)

[tamil vanan (tamilhce)]

@Alelxey thanks giving a prompt suggestion

[Rabi Mishra (rabi)]

When using sessions you should generally use service_type and not an explicit endpoint with endpoint_override with any client. Though we should also support endpoint_override.

[Aleksei Stepanov (penguinolog)]

Sorry, folks, is bugfix really in progress?

[Rabi Mishra (rabi)]

@Alexey,

As mentioned in an earlier comment, why're using endpoint_override when you can easily use service_type with session and keystone does the job finding the endpoint for you? However, there patch is in review to allow endpoint_override to be used.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/367502
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=f2147f79aaa42aedbb8c3413151fade301f468e8
Submitter: Jenkins
Branch: master

commit f2147f79aaa42aedbb8c3413151fade301f468e8
Author: tamilhce <email address hidden>
Date: Fri Sep 9 09:25:41 2016 +0530

    Don't use endpoint_override with session

    We should not use endpoint_override by default and rather
    use service_type with session. This also refactors some of
    the associated code.

    However, if one wants to override the endpoint they can pass
    endpoint_override to the client constructor along with session.

    Change-Id: I7c27d8ff827de3b4bb3e70457c0b6a3f47b6d7bb
    Co-Authored-By: Rabi Mishra <email address hidden>
    Closes-Bug: #1621505

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-heatclient 1.6.0 release.