There's a corner case where password may be requested twice. In a fresh
environment, when schemas have not be downloaded for v2, the client will
ask for a password to download the schemas and then it'll ask for the
password again to run the actual command. This happens because we parse
the CLI arguments twice to make sure we're parsing them for the right
client version.
This patch checks if the password is unset in the newly parsed arguments
and if it's been set in the previously parsed ones. In this case it
keeps the set password. I believe this approach is safer than re-using
the already parsed arguements which may have been parsed for a different
API version (might happen because we fallback to v1 if v2 is not
available).
Reviewed: https:/ /review. openstack. org/219329 /git.openstack. org/cgit/ openstack/ python- glanceclient/ commit/ ?id=1e2274aef01 1c143ef0ae421b4 5755babaff3652
Committed: https:/
Submitter: Jenkins
Branch: master
commit 1e2274aef011c14 3ef0ae421b45755 babaff3652
Author: Flavio Percoco <email address hidden>
Date: Tue Sep 1 18:03:41 2015 +0200
Password should be prompted once
There's a corner case where password may be requested twice. In a fresh
environment, when schemas have not be downloaded for v2, the client will
ask for a password to download the schemas and then it'll ask for the
password again to run the actual command. This happens because we parse
the CLI arguments twice to make sure we're parsing them for the right
client version.
This patch checks if the password is unset in the newly parsed arguments
and if it's been set in the previously parsed ones. In this case it
keeps the set password. I believe this approach is safer than re-using
the already parsed arguements which may have been parsed for a different
API version (might happen because we fallback to v1 if v2 is not
available).
Change-Id: I080253170e3e84 a90363e5bb494cf 137895fe2e7
Closes-bug: #1488892