Comment 11 for bug 1381295

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/129289
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=8c159a2eb4d61f2b9691fbfa1288bcda2156f3f1
Submitter: Jenkins
Branch: master

commit 8c159a2eb4d61f2b9691fbfa1288bcda2156f3f1
Author: Matt Riedemann <email address hidden>
Date: Fri Oct 17 07:53:05 2014 -0700

    Don't set X-Auth-Token key in http session header if no token provided

    Commit f980fc549247fa2deb87dfacebc6d8d13ccd45d1 changed how the
    X-Auth-Token header was scrubbed when logging the request, but
    effectively made the value required which can lead to an AttributeError
    if the value for the header is None.

    The value can be None if you're using Nova but don't have Nova
    configured with auth_strategy='keystone' (see
    nova.image.glance._create_glance_client for details).

    This patch simply checks if the auth_token is set in the http client
    object and if not, it doesn't set the X-Auth-Token key in the session
    header.

    Closes-Bug: #1381295

    Change-Id: Ie285d5253df28a9f0f964147a53c99ceaa919c5c