Comment 10 for bug 672389

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 672389] Re: bzr fast-import crashes on a dump produced by bzr fast-export

On Mon, 2010-11-08 at 16:35 +0000, Eric S. Raymond wrote:
> Jelmer Vernooij <email address hidden>:
> > The contents of the box are:
> >
> > This PPA can be added to your system manually by copying the lines below
> > and adding them to your system's software sources.
> >
> > deb http://ppa.launchpad.net/jelmer/bzr-dailies/ubuntu maverick main
> > deb-src http://ppa.launchpad.net/jelmer/bzr-dailies/ubuntu maverick main
> >
> > Signing key: 1024R/EB27448B
> > Fingerprint: CA7C60A52494B0FD5CD5292102949186EB27448B
>
> I did this.
>
> root@snark:/etc/apt/sources.list.d# cat jelmer-vernooij-bzr-fastimport.list
> deb http://ppa.launchpad.net/jelmer/bzr-dailies/ubuntu maverick main
> root@snark:/etc/apt/sources.list.d#
>
> I got an update of your dailies this way, though it complained of
> being unable to authenticate. Then, because I like authentication, I
> moved the manually-created repo entry to a .save and went
> the add-apt-repository route.
>
> root@snark:/etc/apt/sources.list.d# add-apt-repository ppa:rbelem/bzr-fastimport
> Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --secret-keyring /etc/apt/secring.gpg --trustdb-name /etc/apt/trustdb.gpg --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver keyserver.ubuntu.com --recv 68D4D9D58AB348A98F3C5328BC67161E45243C2D
> gpg: requesting key 45243C2D from hkp server keyserver.ubuntu.com
> gpg: key 45243C2D: public key "Launchpad rbelem-main" imported
> gpg: Total number processed: 1
> gpg: imported: 1 (RSA: 1)
>
> This appeared to succeed, but another attempt at upgrade just to check gave me
> this:
>
> Failed to fetch http://ppa.launchpad.net/rbelem/bzr-fastimport/ubuntu/dists/lucid/main/binary-amd64/Packages.gz 404 Not Found
> Some index files failed to download, they have been ignored, or old ones used instead.
My PPA is ppa:jelmer/bzr-dailies, I'm not sure who rbelem is. :-)
 "apt-add-repository ppa:jelmer/bzr-dailies" should work and take care
 of importing the right GPG key.

It also looks like you're running on Lucid rather than maverick? Or
perhaps the error is referring to an old record?

> Now for more bad news.
>
> esr@snark:~/software/bzr-testrepo$ bzr fast-export --plain
> bzr: ERROR: command 'fast-export' requires argument SOURCE
>
> What the hack is this "source" argument anyway? The on-line help fails to
> explain it. I tried giving it an argument of "." but that crashed the
> exporter. So did the dummy argument "FOO" that it was accepting before.
I'm sorry, it looks like you picked the worst moment to try out
bzr-fastimport as I split python-fastimport out of bzr-fastimport (by
far the largest change in over a year) yesterday evening. This, like the
other issue you ran into, is unexpected fallout of that. I did some
fairly extensive testing of bzr fastimport before doing this split but I
still seem to've missed a few things and apparently uncovered some blind
spots in our testsuite.

The fast-export source argument is the source branch. The second
argument is an optional target file, which defaults to standard out. The
issue you're seeing is a bug, where the opening of stdout fails.
Exporting to a regular file should work.

I've pushed a fix for writing to standard out as well as an additional
unit test that should prevent future regressions in this area. Another
package build is also in progress.

> I note, in the on-line-help, this:
>
> * *commit-properties* - custom metadata per commit that Bazaar stores
> in revision properties (e.g. branch-nick and bugs fixed by this
> change) will be included in the output.
> If commit-properties are now officially part of the format, that's
> one of my feature requests down - but I can't find any indication of
> this in the git docs. What's the actual state of play?
This is a bzr extension. I think bzr will emit it using the new
"feature" extension that should be documented in the git docs. I'm not
sure how official the commit-properties field is.

Cheers,

Jelmer