Comment 4 for bug 1620974

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ceilometerclient (stable/newton)

Reviewed: https://review.openstack.org/366638
Committed: https://git.openstack.org/cgit/openstack/python-ceilometerclient/commit/?id=090e5ffc691c5d40e45ab0c20dc88032a0987b20
Submitter: Jenkins
Branch: stable/newton

commit 090e5ffc691c5d40e45ab0c20dc88032a0987b20
Author: Andrey Kurilin <email address hidden>
Date: Wed Sep 7 12:39:12 2016 +0300

    Fix from_response method to process response from requests

    SessionClient uses requests library. It's response class doesn't have
    "status" property[1], so in case of any errors(with status code > 400),
    from_response method is called and raises AttributeError.

    Also, HTTPClient implementation uses requests lib by default[2](if 'http'
    argument was not transmitted), so from_response method will raise
    AttributeError too.

    [1] - http://docs.python-requests.org/en/master/api/#requests.Response.status_code
    [2] - https://github.com/openstack/python-ceilometerclient/blob/2.6.0/ceilometerclient/openstack/common/apiclient/client.py#L99-L100

    Change-Id: Id8fb2f386e8101951716f30a6365c9aa15bd4b24
    Closes-Bug: #1620974
    (cherry picked from commit 1b1917ab9b56fe92235ce336d3df3e7a8c1c81d2)