Comment 2 for bug 583656

Revision history for this message
Nikoleta Verbeck (nerdynick) wrote :

Your patch is applied and committed to the 0.3.6 Release. Which I'm hoping to release very soon. Just need to wrap up the documentation effort that is the main focus of the release.

I have to say, I never even gave the with statement a thought when it came to transactions. Not a bad idea. There is 1 bug in your implementation but this more relates to a bug I have with transactions in general when it comes to PySQLPool. The 0.4 release should fix the whole transaction model. Currently the problem is when you have multiple connections going out to 1 DB. There is nothing that locks a connection to 1 query object. So some other thread could end up getting into your transaction.