Comment 3 for bug 929618

Revision history for this message
Chris Angove (cangove) wrote : Re: [Bug 929618] The setup.py does not work on all systems and brings in optional elements

Roland-

Awesome. One thing I noticed was the repoze.who version really should be:
">=1.0,<2.0". Basically I found that repose.who 2.0 is not backwards
compatible with 1.0. I assume pysaml was written against repoze.who 1.0.
Might be worth a tweak.

Thanks for the quick fix.

Chris

On 2/9/12 1:40 PM, "Roland Hedberg" <email address hidden> wrote:

>Thanks, applied and check in.
>
>-- Roland
>
>9 feb 2012 kl. 17:01 skrev Chris Angove:
>
>> ** Patch added: "Patch to use test_requires, extras_require and
>>dynamically bring in importlib"
>>
>>https://bugs.launchpad.net/bugs/929618/+attachment/2726969/+files/pysaml_
>>pkg.patch
>>
>> --
>> You received this bug notification because you are a member of pysaml2
>> developers, which is subscribed to pySAML2.
>> https://bugs.launchpad.net/bugs/929618
>>
>> Title:
>> The setup.py does not work on all systems and brings in optional
>> elements
>>
>> Status in Python implementation of SAML2:
>> New
>>
>> Bug description:
>> Setup.py only utilized the install_requires and iinstalls things for
>> tests, optional pieces and has comments. It could be managed all
>> through the code to install the needed pieces and to dynamically
>> detect when to install importlib. I have attached a patch to fix the
>> issues.
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/pysaml2/+bug/929618/+subscriptions
>
>--
>You received this bug notification because you are subscribed to the bug
>report.
>https://bugs.launchpad.net/bugs/929618
>
>Title:
> The setup.py does not work on all systems and brings in optional
> elements
>
>Status in Python implementation of SAML2:
> New
>
>Bug description:
> Setup.py only utilized the install_requires and iinstalls things for
> tests, optional pieces and has comments. It could be managed all
> through the code to install the needed pieces and to dynamically
> detect when to install importlib. I have attached a patch to fix the
> issues.
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/pysaml2/+bug/929618/+subscriptions