Comment 2 for bug 766317

Revision history for this message
Clint Byrum (clint-fewbar) wrote : Re: [Bug 766317] [NEW] debug-log should show relation settings changes

I forgot to chime in here, but I am against this.

Do not write this to a log unless the formula author says its ok. This
data is still "sensitive" and writing it to a log file means it might get
rotated, saved, and examined later, versus having it only in zookeeper
and/or on the nodes while the data is in use.

Let formula authors decide what gets printed, please. I think just taking
the values out from the message below would be fine.. and listing which
values were changed.

Excerpts from Kapil Thangavelu's message of Tue Apr 19 19:00:49 UTC 2011:
> Something along the lines of the following?
>
> unit:mysql/0 hook.invoker flushed values for hook db-relation-changed
> added: username -> 'wordpress'
> added: password -> 'sadr13w0r98uo'
> modified: encoding 'wp1251' -> 'utf-8'
> deleted: timeout -> 12
>
> --
> You received this bug notification because you are a member of Ensemble
> Team, which is the registrant for Ensemble.
> https://bugs.launchpad.net/bugs/766317
>
> Title:
> debug-log should show relation settings changes
>
> Status in Ensemble:
> New
>
> Bug description:
> debug-log should show relation settings changes. These changes along
> with hook firing sequence are key to understanding what's really
> happening