tripleo

puppet-tripleo unit tests are failing due to too new puppet-rabbitmq

Bug #1840641 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Michele Baldessari

Bug Description

Just seen on https://review.opendev.org/#/c/676431/

https://zuul.opendev.org/t/openstack/build/e767db93fe214514bebc065a64288548/log/job-output.txt

We install puppet-rabbitmq 9.1.0 in these jobs:
2019-08-19 06:50:45.754540 | ubuntu-bionic | ├── puppet-rabbitmq (v9.1.0)

So we error out with things like:

2019-08-19 07:19:37.527187 | centos-7 | 1) tripleo::certmonger::rabbitmq on redhat-7-x86_64 behaves like tripleo::certmonger::rabbitmq should include the base for using certmonger

2019-08-19 07:19:37.527435 | centos-7 | Failure/Error: include ::rabbitmq::params

2019-08-19 07:19:37.527514 | centos-7 |

2019-08-19 07:19:37.527713 | centos-7 | Puppet::PreformattedError:

2019-08-19 07:19:37.528769 | centos-7 | Evaluation Error: Error while evaluating a Function Call, Could not find class ::rabbitmq::params for centos-7-rax-ord-0010255916 (file: /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/certmonger/rabbitmq.pp, line: 51, column: 3) on node centos-7-rax-ord-0010255916

2019-08-19 07:19:37.529248 | centos-7 | Shared Example Group: "tripleo::certmonger::rabbitmq" called from ./spec/classes/tripleo_certmonger_rabbitmq_spec.rb:61

2019-08-19 07:19:37.529737 | centos-7 | # ./.bundled_gems/gems/puppet-5.5.16/lib/puppet/parser/compiler.rb:373:in `block in evaluate_classes'

But in rdoinfo via I72306636fd7e49169790801f4fe5683bd0fabf0b we did pin master to a less recent version for exactly this reason 'Pin puppet-rabbitmq to 2cd0fb2abc001a76e7e35446231773e0e54c1ff8'.

(Later in queens/rocky via Id25cdecef6cdc4ada8563ebf0da0f2e0ee38a8df we pinned puppet-rabbitmq to the same version)

Revision history for this message
Michele Baldessari (michele) wrote :

Thanks to Yatin: https://review.opendev.org/#/c/677082/ merged today and moved puppet-rabbitmq to 9.1.0 which is breaking us

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.opendev.org/677173

Changed in tripleo:
assignee: nobody → Michele Baldessari (michele)
status: New → In Progress
Revision history for this message
Michele Baldessari (michele) wrote :

https://review.opendev.org/#/c/677192/ is the revert of https://review.opendev.org/#/c/677082/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/677173
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=1e65c3f4fcc7b49c39a26fbe69a58a9677bdd2d0
Submitter: Zuul
Branch: master

commit 1e65c3f4fcc7b49c39a26fbe69a58a9677bdd2d0
Author: Michele Baldessari <email address hidden>
Date: Mon Aug 19 12:29:11 2019 +0200

    Make puppet-tripleo compatible with latest puppet-rabbitmq

    https://review.opendev.org/#/c/677082/ merged today and moved puppet-rabbitmq to 9.1.0
    which is breaking our spec tests:

    https://zuul.opendev.org/t/openstack/build/e767db93fe214514bebc065a64288548/log/job-output.txt

    So we error out with things like:
    2019-08-19 07:19:37.527187 | centos-7 | 1) tripleo::certmonger::rabbitmq on redhat-7-x86_64 behaves like tripleo::certmonger::rabbitmq should include the base for using certmonger
    2019-08-19 07:19:37.527435 | centos-7 | Failure/Error: include ::rabbitmq::params
    2019-08-19 07:19:37.527713 | centos-7 | Puppet::PreformattedError:
    2019-08-19 07:19:37.528769 | centos-7 | Evaluation Error: Error while evaluating a Function Call, Could not find class ::rabbitmq::params for centos-7-rax-ord-0010255916 (file: /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/certmonger/rabbitmq.pp, line: 51, column: 3) on node centos-7-rax-ord-0010255916

    Let's remove any reference to rabbitmq::params and also the following
    two notifies:
      File[$service_certificate] ~> Service<| title == $::rabbitmq::service_name |>
      File[$service_key] ~> Service<| title == $::rabbitmq::service_name |>

    They do nothing in a containerized deployment anyway.

    Tested as follows:
    - Full downstream OSP15 HA deploy

    Change-Id: Ib7c373c10ff7bcd8ec33cb912a8a0a4a32a196e2
    Closes-Bug: #1840641

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 11.2.0

This issue was fixed in the openstack/puppet-tripleo 11.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/737715

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/737716

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/stein)

Reviewed: https://review.opendev.org/737715
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8ee23da39ae0ea7a9d0b44c89bcf3e07dab848f8
Submitter: Zuul
Branch: stable/stein

commit 8ee23da39ae0ea7a9d0b44c89bcf3e07dab848f8
Author: Michele Baldessari <email address hidden>
Date: Mon Aug 19 12:29:11 2019 +0200

    Make puppet-tripleo compatible with latest puppet-rabbitmq

    https://review.opendev.org/#/c/677082/ merged today and moved puppet-rabbitmq to 9.1.0
    which is breaking our spec tests:

    https://zuul.opendev.org/t/openstack/build/e767db93fe214514bebc065a64288548/log/job-output.txt

    So we error out with things like:
    2019-08-19 07:19:37.527187 | centos-7 | 1) tripleo::certmonger::rabbitmq on redhat-7-x86_64 behaves like tripleo::certmonger::rabbitmq should include the base for using certmonger
    2019-08-19 07:19:37.527435 | centos-7 | Failure/Error: include ::rabbitmq::params
    2019-08-19 07:19:37.527713 | centos-7 | Puppet::PreformattedError:
    2019-08-19 07:19:37.528769 | centos-7 | Evaluation Error: Error while evaluating a Function Call, Could not find class ::rabbitmq::params for centos-7-rax-ord-0010255916 (file: /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/certmonger/rabbitmq.pp, line: 51, column: 3) on node centos-7-rax-ord-0010255916

    Let's remove any reference to rabbitmq::params and also the following
    two notifies:
      File[$service_certificate] ~> Service<| title == $::rabbitmq::service_name |>
      File[$service_key] ~> Service<| title == $::rabbitmq::service_name |>

    They do nothing in a containerized deployment anyway.

    Tested as follows:
    - Full downstream OSP15 HA deploy

    Change-Id: Ib7c373c10ff7bcd8ec33cb912a8a0a4a32a196e2
    Closes-Bug: #1840641
    (cherry picked from commit 1e65c3f4fcc7b49c39a26fbe69a58a9677bdd2d0)

tags: added: in-stable-stein
tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/queens)

Reviewed: https://review.opendev.org/737716
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c37d05692c62a71bd52d82a692cb43086aa0abfd
Submitter: Zuul
Branch: stable/queens

commit c37d05692c62a71bd52d82a692cb43086aa0abfd
Author: Michele Baldessari <email address hidden>
Date: Mon Aug 19 12:29:11 2019 +0200

    Make puppet-tripleo compatible with latest puppet-rabbitmq

    https://review.opendev.org/#/c/677082/ merged today and moved puppet-rabbitmq to 9.1.0
    which is breaking our spec tests:

    https://zuul.opendev.org/t/openstack/build/e767db93fe214514bebc065a64288548/log/job-output.txt

    So we error out with things like:
    2019-08-19 07:19:37.527187 | centos-7 | 1) tripleo::certmonger::rabbitmq on redhat-7-x86_64 behaves like tripleo::certmonger::rabbitmq should include the base for using certmonger
    2019-08-19 07:19:37.527435 | centos-7 | Failure/Error: include ::rabbitmq::params
    2019-08-19 07:19:37.527713 | centos-7 | Puppet::PreformattedError:
    2019-08-19 07:19:37.528769 | centos-7 | Evaluation Error: Error while evaluating a Function Call, Could not find class ::rabbitmq::params for centos-7-rax-ord-0010255916 (file: /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/certmonger/rabbitmq.pp, line: 51, column: 3) on node centos-7-rax-ord-0010255916

    Let's remove any reference to rabbitmq::params and also the following
    two notifies:
      File[$service_certificate] ~> Service<| title == $::rabbitmq::service_name |>
      File[$service_key] ~> Service<| title == $::rabbitmq::service_name |>

    They do nothing in a containerized deployment anyway.

    Tested as follows:
    - Full downstream OSP15 HA deploy

    Change-Id: Ib7c373c10ff7bcd8ec33cb912a8a0a4a32a196e2
    Closes-Bug: #1840641
    (cherry picked from commit 1e65c3f4fcc7b49c39a26fbe69a58a9677bdd2d0)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo queens-eol

This issue was fixed in the openstack/puppet-tripleo queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo stein-eol

This issue was fixed in the openstack/puppet-tripleo stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.