Upgrades in Stein are incomplete

[Jiří Stránský]

This is a sort of "catch-all" bug for upgrade implementation pieces missing in stable/stein. Some of the patches have their own bugs, but others are simply not-yet-implemented parts. For the latter we can reference this bug when backporting.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/664277

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/664277
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=df3b4b3c5724d0736227e3dc136dd6f797b02678
Submitter: Zuul
Branch: master

commit df3b4b3c5724d0736227e3dc136dd6f797b02678
Author: Jiri Stransky <email address hidden>
Date: Mon Jun 10 14:14:33 2019 +0200

    Configure insecure registries before Pacemaker-managed image pulls

    Service templates like mysql-pacemaker-puppet.yaml pull fresh
    container images in step 2 of the upgrade tasks. In case they come
    from an allowed insecure registry, the insecure registries setting
    must be in place by step 1. We do just that by reusing the "install
    and configure Podman" part of host_prep_tasks.

    Change-Id: I36e003c09d7f7768da475d166a20f01347a2934c
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/667098

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/667099

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667136

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667138

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667139

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667140

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667141

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667144

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667146

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667098
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2ca7c550390f5978d1dab3c78a1b84fe073f8ed0
Submitter: Zuul
Branch: master

commit 2ca7c550390f5978d1dab3c78a1b84fe073f8ed0
Author: Jiri Stransky <email address hidden>
Date: Mon Jun 24 12:32:30 2019 +0200

    Allow skipping RHSM with Leapp

    Useful when developing and testing.

    Also, we don't need to be explicitly installing RHSM, instead we
    should ensure that it doesn't get removed by accident if it needs to
    be present.

    Change-Id: I65ccf3436bf3816b52c40a7e154511ab3a2e43be
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667099
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=56a35beb51c050a928bf0ba6d82e730e730966ab
Submitter: Zuul
Branch: master

commit 56a35beb51c050a928bf0ba6d82e730e730966ab
Author: Jiri Stransky <email address hidden>
Date: Mon Jun 24 12:32:37 2019 +0200

    Idempotency for system_upgrade_prepare

    Partial-Bug: #1831690
    Change-Id: I9510fd00755cf33df105ef637d047d3cb87243ae

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667915

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667916

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667136
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8d6b51b775ae635c2faa6f42b2b206210b52097b
Submitter: Zuul
Branch: stable/stein

commit 8d6b51b775ae635c2faa6f42b2b206210b52097b
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Apr 10 18:11:24 2019 +0200

    Stop all services before upgrading node's OS.

    During the system_upgrade_prepare step in the upgrade
    workflow, we need to stop all services before starting
    the operating system upgrade, we're doing that by stopping
    all docker containers at once after stopping the pcmkr
    cluster in step 2.

    Partial-Bug: #1831690
    Change-Id: I50a1289a864f804d02a2e2bc0ca8738a186beff0
    (cherry picked from commit 9d5c972d99afbb05713200021bb8b4b1eb17a851)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667138
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7f393a3d40b402e1ce412dcff487052763cf470f
Submitter: Zuul
Branch: stable/stein

commit 7f393a3d40b402e1ce412dcff487052763cf470f
Author: Jiri Stransky <email address hidden>
Date: Tue May 7 16:26:19 2019 +0200

    Add operating system upgrade preparation via Leapp

    Also make sure pacemaker cluster is not only stopped but also
    destroyed on the node being upgraded. This is a prerequisite for
    upgrades via Leapp, otherwise Leapp would assume we expect it to
    upgrade the cluster, and it would fail on validation.

    Partial-Bug: #1831690
    Change-Id: I8cf3e4cf294fee3b71473e2343ad16b184fac665
    (cherry picked from commit b0519479c19766e23c82a21a4b476b350f096941)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667139
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=34450cc635e8dfc7e6f1bb406cb9e7fd978a2db5
Submitter: Zuul
Branch: stable/stein

commit 34450cc635e8dfc7e6f1bb406cb9e7fd978a2db5
Author: Jiri Stransky <email address hidden>
Date: Fri May 10 15:52:49 2019 +0200

    Remove OpenStack packages right before upgrading the operating system

    This could make the upgrade faster, but mainly it's less likely that
    something will go wrong when the node goes down for the offline
    upgrade. We want to minimize the chances of that happening, because
    such error is extremely unpleasant to deal with (restore from backup
    might be the only solution at that point).

    Partial-Bug: #1831690
    Change-Id: Iddf30278f0cb4eb93fcbd8dc829e247bfb534562
    (cherry picked from commit bf8cde549b60a0621b9188a3d99f1610ba062009)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667140
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0af8eb1c64a3079717c361b04523b0be228d3c1a
Submitter: Zuul
Branch: stable/stein

commit 0af8eb1c64a3079717c361b04523b0be228d3c1a
Author: Jose Luis Franco Arza <email address hidden>
Date: Fri Mar 15 19:07:42 2019 +0100

    Remove baremetal to containerized pacemaker upgrade_tasks.

    Now that all pacemaker managed services are containerized
    there is no need to keep these upgrade_tasks.

    Partial-Bug: #1831690
    Change-Id: I6531563b4da8cf9a9c93a99243720def182f332b
    (cherry picked from commit 0e6769b4b8225b780367e323b864e33571e21706)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667141
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2accf4d25d87d3be6b1aaf3772d00252a2364f60
Submitter: Zuul
Branch: stable/stein

commit 2accf4d25d87d3be6b1aaf3772d00252a2364f60
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Mar 18 12:29:55 2019 +0100

    Refactor ovn_dbs upgrade_tasks.

    Reorder the upgrade_tasks for the ovn_dbs service in a similar way
    it's being done for the rest of pacemaker managed services. Also,
    ensure indempotency in the case the cluster is down as it will occur
    for the S to R upgrades workflow.

    Partial-Bug: #1831690
    Change-Id: I8fe302607544653032a011f1c932647adec5bfa0
    (cherry picked from commit 05f4b253b84526850959f1b827a261b7573c006c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667144
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=273f9a32a787198904cdb8ca4971764ba2d53382
Submitter: Zuul
Branch: stable/stein

commit 273f9a32a787198904cdb8ca4971764ba2d53382
Author: Jiri Stransky <email address hidden>
Date: Mon Jun 10 14:14:33 2019 +0200

    Configure insecure registries before Pacemaker-managed image pulls

    Service templates like mysql-pacemaker-puppet.yaml pull fresh
    container images in step 2 of the upgrade tasks. In case they come
    from an allowed insecure registry, the insecure registries setting
    must be in place by step 1. We do just that by reusing the "install
    and configure Podman" part of host_prep_tasks.

    Change-Id: I36e003c09d7f7768da475d166a20f01347a2934c
    Partial-Bug: #1831690
    (cherry picked from commit df3b4b3c5724d0736227e3dc136dd6f797b02678)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/669122

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667146
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5f40f0e80865cf079b6c007d8af839ab0ba9d3bc
Submitter: Zuul
Branch: stable/stein

commit 5f40f0e80865cf079b6c007d8af839ab0ba9d3bc
Author: Jiri Stransky <email address hidden>
Date: Thu Jun 6 14:09:37 2019 +0200

    Upgrade playbook fixes for OS upgrade

    These are remaining fixes for pacemaker and mysql tasks to make
    upgrade_steps_playbook.yaml pass on machines after operating system
    upgrade to EL 8.

    Partial-Bug: #1831690
    Change-Id: If8c97752463e560c60d35e10081b5105816e66f6
    (cherry picked from commit 6baf5326bfb949bce61997e65570fdfc38638f47)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667915
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=367f4decd9bea7f41db44898309dfda86b85a435
Submitter: Zuul
Branch: stable/stein

commit 367f4decd9bea7f41db44898309dfda86b85a435
Author: Jiri Stransky <email address hidden>
Date: Mon Jun 24 12:32:30 2019 +0200

    Allow skipping RHSM with Leapp

    Useful when developing and testing.

    Also, we don't need to be explicitly installing RHSM, instead we
    should ensure that it doesn't get removed by accident if it needs to
    be present.

    Change-Id: I65ccf3436bf3816b52c40a7e154511ab3a2e43be
    Partial-Bug: #1831690
    (cherry picked from commit 2ca7c550390f5978d1dab3c78a1b84fe073f8ed0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667916
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=29fa95801113d527b8fa3fbee7e73ca060310988
Submitter: Zuul
Branch: stable/stein

commit 29fa95801113d527b8fa3fbee7e73ca060310988
Author: Jiri Stransky <email address hidden>
Date: Mon Jun 24 12:32:37 2019 +0200

    Idempotency for system_upgrade_prepare

    Partial-Bug: #1831690
    Change-Id: I9510fd00755cf33df105ef637d047d3cb87243ae
    (cherry picked from commit 56a35beb51c050a928bf0ba6d82e730e730966ab)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/670062

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jiri Stransky (<email address hidden>) on branch: master
Review: https://review.opendev.org/669122
Reason: Reporting upstream+downstream bugs for this to be solved better

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/670062
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2b427970a36a63cc2b9afbd61f10fe033287aca5
Submitter: Zuul
Branch: master

commit 2b427970a36a63cc2b9afbd61f10fe033287aca5
Author: Jiri Stransky <email address hidden>
Date: Wed Jul 10 15:24:13 2019 +0200

    Handle edge cases in staged upgrade hiera data

    We make sure the hiera is set in an either-or branches so that we
    prevent from executing both at the same time or none at all.

    Edge case 1 which is not that much of an edge case --
    single-controller environment with Pacemaker. Previously we ran both
    branches resulting in duplicate entries.

    Edge case 2 -- having the service in roles data but having no node
    assigned to that role. In that case previously we wouldn't set the
    variables and the upgrade would fail.

    Change-Id: I1681a5e5ac7842500fc5e9dd0900ee6121773537
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/673799

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673799
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=945a22166c48079d903d88287870e0391b772f45
Submitter: Zuul
Branch: stable/stein

commit 945a22166c48079d903d88287870e0391b772f45
Author: Jiri Stransky <email address hidden>
Date: Wed Jul 10 15:24:13 2019 +0200

    Handle edge cases in staged upgrade hiera data

    We make sure the hiera is set in an either-or branches so that we
    prevent from executing both at the same time or none at all.

    Edge case 1 which is not that much of an edge case --
    single-controller environment with Pacemaker. Previously we ran both
    branches resulting in duplicate entries.

    Edge case 2 -- having the service in roles data but having no node
    assigned to that role. In that case previously we wouldn't set the
    variables and the upgrade would fail.

    Change-Id: I1681a5e5ac7842500fc5e9dd0900ee6121773537
    Partial-Bug: #1831690
    (cherry picked from commit 2b427970a36a63cc2b9afbd61f10fe033287aca5)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/675629

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675629
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e26009fa9c57d42a0c82ebc22169e10741005946
Submitter: Zuul
Branch: master

commit e26009fa9c57d42a0c82ebc22169e10741005946
Author: Jiri Stransky <email address hidden>
Date: Fri Aug 9 15:52:29 2019 +0200

    Check for rc instead of |succeeded

    We went from `ignore_errors: true` to `failed_when: false` to prevent
    Ansible printing errors which aren't really errors. When using
    `succeeded` filter on a registered variable from such task, we will
    always get true, which is not what we want. Check for `.rc == 0`
    instead to set the facts as they were intended.

    Change-Id: Ib8dea68720fda86cf4fd879cdf194d206968f6fb
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/676169

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/676173

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/676187

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/676194

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676169
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9ee30cdeb468e2154c9ba70d1d7c338240f5ea36
Submitter: Zuul
Branch: stable/stein

commit 9ee30cdeb468e2154c9ba70d1d7c338240f5ea36
Author: Jiri Stransky <email address hidden>
Date: Fri Aug 9 15:52:29 2019 +0200

    Check for rc instead of |succeeded

    We went from `ignore_errors: true` to `failed_when: false` to prevent
    Ansible printing errors which aren't really errors. When using
    `succeeded` filter on a registered variable from such task, we will
    always get true, which is not what we want. Check for `.rc == 0`
    instead to set the facts as they were intended.

    Change-Id: Ib8dea68720fda86cf4fd879cdf194d206968f6fb
    Partial-Bug: #1831690
    (cherry picked from commit e26009fa9c57d42a0c82ebc22169e10741005946)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676173
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d4db2fa532c81c7c7ed13f45cb22d22ed42011bf
Submitter: Zuul
Branch: master

commit d4db2fa532c81c7c7ed13f45cb22d22ed42011bf
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 13 13:59:44 2019 +0200

    Force re-run of pacemaker bundle init containers during upgrade-scaleup

    We need to recreate the *_init_bundle containers during the staged
    upgrade (upgrade-scaleup), because the init containers will e.g. set
    the correct replica count for the bundle as we're scaling up from 1 to
    3 controllers.

    The init containers wouldn't get re-run/recreated automatically on
    upgrade-scaleup because none of their input would change. The
    DeploymentIdentifier is set by the `openstack upgrade prepare` command
    and applied during upgrade with `--limit controller-0`. Then later
    when we run `--limit controller-0,controller-1`, the
    DeploymentIdentifier value does not change from the perspective of
    controller-0, so we have to explicitly remove the bundle init
    containers to force re-running them.

    Change-Id: I93c6d7292f37529735e24286f4076634aa4fe6a5
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/677057

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/677140

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/677057
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4b9c3637f8e58193d6efdb72f8fb447c2c6c66f2
Submitter: Zuul
Branch: stable/stein

commit 4b9c3637f8e58193d6efdb72f8fb447c2c6c66f2
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 13 13:59:44 2019 +0200

    Force re-run of pacemaker bundle init containers during upgrade-scaleup

    We need to recreate the *_init_bundle containers during the staged
    upgrade (upgrade-scaleup), because the init containers will e.g. set
    the correct replica count for the bundle as we're scaling up from 1 to
    3 controllers.

    The init containers wouldn't get re-run/recreated automatically on
    upgrade-scaleup because none of their input would change. The
    DeploymentIdentifier is set by the `openstack upgrade prepare` command
    and applied during upgrade with `--limit controller-0`. Then later
    when we run `--limit controller-0,controller-1`, the
    DeploymentIdentifier value does not change from the perspective of
    controller-0, so we have to explicitly remove the bundle init
    containers to force re-running them.

    Change-Id: I93c6d7292f37529735e24286f4076634aa4fe6a5
    Partial-Bug: #1831690
    (cherry picked from commit d4db2fa532c81c7c7ed13f45cb22d22ed42011bf)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676187
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=206625d4f5bd9a643e76d7f52e13cc171ee4edad
Submitter: Zuul
Branch: master

commit 206625d4f5bd9a643e76d7f52e13cc171ee4edad
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 13 15:01:44 2019 +0200

    Allow combining system_upgrade_prepare and system_upgrade_run into system_upgrade

    Previously we required the operator to run two separate commands for
    the "prepare" and "run" phases of operating system upgrade. This
    commit refactors the upgrade_tasks with these tags so that running the
    whole system upgrade is possible via a single command with `--tags
    system_upgrade`.

    Allowing to run in a single command requires being more careful about
    what can happen in which step number in the upgrade tasks. The upgrade
    steps for system upgrade are now explicitly documented in composable
    services readme.

    The existing system_upgrade_run and system_upgrade_prepare tasks were
    checked and moved into the appropriate steps. In the case of
    pacemaker, it required moving the cluster stop/destroy action into a
    single file with removing all containers, to guarantee that the
    cluster is stopped before the container removal, otherwise pacemaker
    would try to spawn new containers.

    Change-Id: I3cd78de8d07be46ee01006dd7e039c285991d14a
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/677140
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7f7960a5367e29647cd79a6325f7ca857a2d0084
Submitter: Zuul
Branch: stable/stein

commit 7f7960a5367e29647cd79a6325f7ca857a2d0084
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 13 15:01:44 2019 +0200

    Allow combining system_upgrade_prepare and system_upgrade_run into system_upgrade

    Previously we required the operator to run two separate commands for
    the "prepare" and "run" phases of operating system upgrade. This
    commit refactors the upgrade_tasks with these tags so that running the
    whole system upgrade is possible via a single command with `--tags
    system_upgrade`.

    Allowing to run in a single command requires being more careful about
    what can happen in which step number in the upgrade tasks. The upgrade
    steps for system upgrade are now explicitly documented in composable
    services readme.

    The existing system_upgrade_run and system_upgrade_prepare tasks were
    checked and moved into the appropriate steps. In the case of
    pacemaker, it required moving the cluster stop/destroy action into a
    single file with removing all containers, to guarantee that the
    cluster is stopped before the container removal, otherwise pacemaker
    would try to spawn new containers.

    Change-Id: I3cd78de8d07be46ee01006dd7e039c285991d14a
    Partial-Bug: #1831690
    (cherry picked from commit 206625d4f5bd9a643e76d7f52e13cc171ee4edad)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676194
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=86d425601495550282119be035180bdbc71cfc57
Submitter: Zuul
Branch: master

commit 86d425601495550282119be035180bdbc71cfc57
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 13 15:42:18 2019 +0200

    Set EnablePackageInstall to true by default for in-place OS upgrade

    For in-place upgrades via Leapp, which is the default, we are
    dependent on package installs. User can still override the default
    value if they wish so, but they might have to pull in the content by
    some manual means.

    Change-Id: I5e5629d2baed97988bc65151d51c115a2a263dfc
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/679003

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/679003
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3f576469144311ff822884651d0717ee8836f02c
Submitter: Zuul
Branch: stable/stein

commit 3f576469144311ff822884651d0717ee8836f02c
Author: Jiri Stransky <email address hidden>
Date: Tue Aug 13 15:42:18 2019 +0200

    Set EnablePackageInstall to true by default for in-place OS upgrade

    For in-place upgrades via Leapp, which is the default, we are
    dependent on package installs. User can still override the default
    value if they wish so, but they might have to pull in the content by
    some manual means.

    Change-Id: I5e5629d2baed97988bc65151d51c115a2a263dfc
    Partial-Bug: #1831690
    (cherry picked from commit 86d425601495550282119be035180bdbc71cfc57)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/684963

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/685226

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/685229

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/684963
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=0708730ec6e5985d43e43e669528bf372bc8d7f1
Submitter: Zuul
Branch: stable/stein

commit 0708730ec6e5985d43e43e669528bf372bc8d7f1
Author: Jiri Stransky <email address hidden>
Date: Thu Sep 26 09:52:27 2019 +0200

    [Stein] Optional flag file for tripleo-transfer to prevent overwriting

    When using tripleo-transfer role, optionally a file will be created at
    a path specified by tripleo_tranfer_flag_file variable (if set). The
    transfer will be prevented in case the file already exists. This is to
    ensure the data transfer happens only once and the data is not
    overwritten by accident.

    The corresponding change I3a08949436dcb634df34622c9aeead552dd38443 for
    master branch has to go to tripleo-ansible repo.

    Change-Id: I6176e3c9998d8b03d927d1741a1af2946bf2588d
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685226
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=60b0359b83adc8cd6d7391ceab3bb6c2a4e346d7
Submitter: Zuul
Branch: master

commit 60b0359b83adc8cd6d7391ceab3bb6c2a4e346d7
Author: Jiri Stransky <email address hidden>
Date: Fri Sep 27 10:18:22 2019 +0200

    Prevent running mysql data transfer twice by accident

    Providing the tripleo_transfer_flag_file parameter means the data
    transfer would stop (fail intentionally) if it has been already run
    previously.

    Change-Id: If81b1ce9ef381ff102a6ce71fa4603424deca01d
    Partial-Bug: #1831690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685229
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=603ae5d3e47297c21df69c57cbc7c2354bbc9f70
Submitter: Zuul
Branch: stable/stein

commit 603ae5d3e47297c21df69c57cbc7c2354bbc9f70
Author: Jiri Stransky <email address hidden>
Date: Fri Sep 27 10:18:22 2019 +0200

    Prevent running mysql data transfer twice by accident

    Providing the tripleo_transfer_flag_file parameter means the data
    transfer would stop (fail intentionally) if it has been already run
    previously.

    Change-Id: If81b1ce9ef381ff102a6ce71fa4603424deca01d
    Partial-Bug: #1831690
    (cherry-picked from 60b0359b83adc8cd6d7391ceab3bb6c2a4e346d7)

[Jiří Stránský (jistr)]

Stale bug, let's reopen if necessary.