Comment 12 for bug 1671681

Reviewed: https://review.openstack.org/561742
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=482bf9695fb49c9bc59785510978cd2f973b3bba
Submitter: Zuul
Branch: stable/ocata

commit 482bf9695fb49c9bc59785510978cd2f973b3bba
Author: Diana Clarke <email address hidden>
Date: Tue Mar 7 14:07:16 2017 -0500

    Correct permissions on the nova logfiles

    When you execute nova-manage commands, oslo logs to the following
    location (file name is dynamically created based on command name).

        /var/log/nova/nova-manage.log

    Because puppet-nova is executing these commands as root,
    nova-manage.log is owned by root, preventing the 'nova-manage
    db archive_deleted_rows' entry in nova's crontab from executing.

        Permission denied: '/var/log/nova/nova-manage.log'

    This log file is also an outlier, as all other log files in
    /var/log/nova/ are owned by nova:nova.

    Similar issues are possible for other nova logs, if for example
    a nova services is initially started manually as root, so the
    ownership of all nova logs is corrected before configuring nova.

    Co-Authored-By: Oliver Walsh <email address hidden>
    Co-Authored-By: Diana Clarke <email address hidden>
    Co-Authored-By: Maciej Kucia <email address hidden>
    Closes-Bug: #1671681
    Change-Id: I0ca0110cbf9139c79074cf603dcab9135f96e765
    (cherry picked from commit e128ba6538eb806589ebc01c16ee5e298bb0ee86)
    (cherry picked from commit 0d6f9e10749959b0fe88c876319ca03ddac1b34e)