glance service name is 'Image Service' instead of 'glance'

[Dan Prince]

The service_name is typically set to the project name for most projects. When querying the keystone catalog consistent use of the service_name and service_type is important to be able to select the right endpoints.

For glance we set service_name to 'Image Service' in the keystone::auth manifest. This causes endpoint lookup to fail for service like Mistral which expect it to be 'glance'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/319464

[Dan Prince (dan-prince)]

This is an example using instack undercloud which typically uses the puppet defaults. Note that glance is the only service which doesn't use the project name as 'name'.

MariaDB [keystone]> select extra from service;
+---------------------------------------------------------------------------------+
| extra |
+---------------------------------------------------------------------------------+
| {"description": "Openstack Compute Service v3", "name": "novav3"} |
| {"description": "OpenStack Image Service", "name": "Image Service"} |
| {"description": "Bare Metal Introspection Service", "name": "ironic-inspector"} |
| {"description": "OpenStack Workflow Service", "name": "mistral"} |
| {"description": "Openstack Orchestration Service", "name": "heat"} |
| {"description": "Neutron Networking Service", "name": "neutron"} |
| {"description": "Ironic Bare Metal Provisioning Service", "name": "ironic"} |
| {"description": "Openstack Object-Store Service", "name": "swift"} |
| {"description": "OpenStack Identity Service", "name": "keystone"} |
| {"description": "Openstack Compute Service", "name": "nova"} |
| {"description": "Openstack messaging Service", "name": "zaqar"}

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/319464
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=44bf1232a50f69ff62955fc7c1c8ab48e04bc7ff
Submitter: Jenkins
Branch: master

commit 44bf1232a50f69ff62955fc7c1c8ab48e04bc7ff
Author: Dan Prince <email address hidden>
Date: Fri May 20 17:33:22 2016 -0400

    Switch $service_name to 'glance' for keystone

    This patch switches the service name from 'Image Service' to
    just 'glance' so that it matches what we do for other services.
    Typically we use the project (auth) name for the service_name.

    Not having a consistent catalog can cause failure to find
    endpoints for some services. Mistral for example would fail
    to lookup the glance endpoint due to it being set as 'Image Service'
    rather than 'glance'.

    Change-Id: I17116c0f995ab76ed79bd8b2df57629c1ed4e4d0
    Closes-bug: #1584229

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-glance 9.1.0 release.