Comment 2 for bug 1312054

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Addressed by: https://review.openstack.org/90022

Was before (wrong!)
glance::notify::rabbitmq
  should contain Glance_api_config[DEFAULT/notifier_driver] with value => "rabbit"
  should contain Glance_api_config[DEFAULT/rabbit_password] with value => "pass"
  should contain Glance_api_config[DEFAULT/rabbit_userid] with value => "guest"
  should contain Glance_api_config[DEFAULT/rabbit_host] with value => "localhost"
  should contain Glance_api_config[DEFAULT/rabbit_port] with value => "5672"
  should contain Glance_api_config[DEFAULT/rabbit_virtual_host] with value => "/"
  should contain Glance_api_config[DEFAULT/rabbit_notification_exchange] with value => "glance"
  should contain Glance_api_config[DEFAULT/rabbit_notification_topic] with value => "notifications"

With the fix(right)
glance::notify::rabbitmq
  when defaults with rabbit pass specified
    should contain Glance_api_config[DEFAULT/notifier_driver] with value => "rabbit"
    should contain Glance_api_config[DEFAULT/rabbit_password] with value => "pass"
    should contain Glance_api_config[DEFAULT/rabbit_userid] with value => "guest"
    should contain Glance_api_config[DEFAULT/rabbit_host] with value => "localhost"
    should contain Glance_api_config[DEFAULT/rabbit_port] with value => "5672"
    should contain Glance_api_config[DEFAULT/rabbit_hosts] with value => "localhost:5672"
    should contain Glance_api_config[DEFAULT/rabbit_ha_queues] with value => "false"
    should contain Glance_api_config[DEFAULT/amqp_durable_queues] with value => "false"
    should contain Glance_api_config[DEFAULT/rabbit_virtual_host] with value => "/"
    should contain Glance_api_config[DEFAULT/rabbit_notification_exchange] with value => "glance"
    should contain Glance_api_config[DEFAULT/rabbit_notification_topic] with value => "notifications"
  when passing params for single rabbit host
    should contain Glance_api_config[DEFAULT/rabbit_userid] with value => "guest2"
    should contain Glance_api_config[DEFAULT/rabbit_host] with value => "localhost2"
    should contain Glance_api_config[DEFAULT/rabbit_port] with value => "5673"
    should contain Glance_api_config[DEFAULT/rabbit_hosts] with value => "localhost2:5673"
    should contain Glance_api_config[DEFAULT/rabbit_use_ssl] with value => "true"
    should contain Glance_api_config[DEFAULT/amqp_durable_queues] with value => "true"
  when passing params for multiple rabbit hosts
    should contain Glance_api_config[DEFAULT/rabbit_userid] with value => "guest3"
    should contain Glance_api_config[DEFAULT/rabbit_hosts] with value => "nonlocalhost3:5673,nonlocalhost4:5673"
    should contain Glance_api_config[DEFAULT/rabbit_ha_queues] with value => "true"
    should not contain Glance_api_config[DEFAULT/rabbit_port]
    should not contain Glance_api_config[DEFAULT/rabbit_host]