Comment 5 for bug 474162

Revision history for this message
nkmrshn (nkmrshn) wrote :

Thank you very much indeed.

I agree with you about the setPersonal, but when I looked at mvc/Mailer.java (r678) I found,

  public static void setPersonal(String personal)

I think you should remove this.

In the libs/Mail.java (r678, line 178),

  return sendMessage(buildMessage(from, replyTo, recipients, subject, body, alternate, contentType, attachments));

since you are not calling buildMessage with charset and headers variables, buildMessage function (line 210) will never called from mvc/Mailer.java. So, it should be,

  return sendMessage(buildMessage(from, replyTo, recipients, subject, body, alternate, contentType, charset, headers, attachments));

Also, addHeaders, in line 231 libs/Mail.java, MUST be after msg.setText, because setText will over write the "Content-Transfer-Encoding" header. So even if I wrote,

 addHeader("Content-Transfer-Encoding", "7bit");

the header will be, "Content-Transfer-Encoding: quoted-printable". Please move addHeaders to between line 280 and 281.