Comment 4 for bug 474162

Revision history for this message
Nicolas Leroux (nicolas-lunatech) wrote :

I have committed something that allows to your character encoding for the whole message inspired by your patch.

I also committed the additional headers from your patch file. However, I did not commit the fix for the setPersonal as you can do that using the setFrom ie setFrom("Blabla <email address hidden>").

I preserved the old methods so the API is not changed (the API is Frozen for the 1.0 branch). I only need 2 extra tests to close this issue (one for the headers and one for the encoding). Maybe you can come up with a good test case?

I also start thinking that the sendMail as too many arguments so we might want to use a Mail object to leverage the calls ie :

Mail mail = new Mail();
mail.setFrom()
mail.addHeaders();

But that is an API change and that would be for the 1.1 branch. I also don't want to end up redoing the jakarta commons email (http://commons.apache.org/email/) so we will have to see how relevant that is.