Actually, Rob is right. In DBPlugin.java, at the onApplicationStart method, it's assumed that a database connection is started through db.X properties. In the change() method, it appears that the db property only accounts for the following values:
- mem
- fs
- mysql.*
If db.driver or db.url are null then it's assumed that the configuration didn't change and onApplicationStart() won't actually do anything. In effect, using a database connection pool through JNDI is not supported and I think that Rob should submit a patch and you should consider to merge it quickly.
When you're using the WAR export feature, editing the application.conf just to change the database settings is a major pain in the ass as far as operation teams are concerned.
Actually, Rob is right. In DBPlugin.java, at the onApplicationStart method, it's assumed that a database connection is started through db.X properties. In the change() method, it appears that the db property only accounts for the following values:
- mem
- fs
- mysql.*
If db.driver or db.url are null then it's assumed that the configuration didn't change and onApplicationSt art() won't actually do anything. In effect, using a database connection pool through JNDI is not supported and I think that Rob should submit a patch and you should consider to merge it quickly.
When you're using the WAR export feature, editing the application.conf just to change the database settings is a major pain in the ass as far as operation teams are concerned.