Comment 4 for bug 1037731

Revision history for this message
Rod Smith (rodsmith) wrote :

I'm not sure if this bug report is valid any more. If I'm correctly interpreting your original description, Jeff, the test was looking for a line that included the string "START OF READ". That line wasn't always present, so the test was failing. The current disk_smart script doesn't include any code that looks for such a line, though. When I got it, the code was looking for "SMART support is: Available" and "SMART support is: Enabled" in specific lines near the end of the output. One of my changes (in https://code.launchpad.net/~rodsmith/checkbox/smart-detection) was to generalize this because I found some disks that added an extra blank line at the end of the output, which resulted in failure to find the strings that were actually present, just at the wrong place. My latest patch now searches for those strings (or their component substrings; there's some variability in the number of spaces, too!) anywhere in the "smartctl -i" output.

If I'm right, then this bug can be closed out, since it was probably fixed in some previous revision, or maybe it's actually a duplicate of the bug I've filed and fixed. If you know what machine produced that buggy behavior, though, it would be best to check the latest version of the script on it.