While typing text it has shadows

Bug #889453 reported by grofaty on 2011-11-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pinta
Medium
Unassigned

Bug Description

Pinta 1.1 on Ubuntu 11.10.

1. Select Text object and click on canvas.
2. Select red color as primary color.
3. Start typing. Notice this text has a shadows (black color).
4. Press <Esc> key to exit Text object. Now text appears without shadows.
This is not a big issue, but it is annoying to see text that will not be displayed when finished.

See attachment: above text while typing, bellow text after <Esc> is pressed.

grofaty (grofaty) wrote :
Changed in pinta:
importance: Undecided → Medium
status: New → Confirmed
grofaty (grofaty) wrote :

Just out of curiosity it looks like pinta.po file is treated as two files you know "pinta" and "po". It looks like there was some problem during import of po file. Does import script works correctly?

grofaty (grofaty) wrote :

I see #2 was most probably wrong copy/pasted. This issue is reported at bug 889435 and commend can be ignored in this bug report. Sorry for confusion.

OK, back to the topic. Tested the problem in bug report on Pinta 1.2 on Windows and latest development on Ubuntu 11.10 and problem persists.

tags: added: text-tool
Rini (rini182006) wrote :

hi, this rini. i would like to work on this bug

grofaty (grofaty) wrote :

Rini, at the top of this web page at column "Assigned to" click on Unassigned and then when window appears click on Assign me. This action means you will be working on this bug and so someone else will not duplicate the effort.

Rini (rini182006) on 2012-08-15
Changed in pinta:
assignee: nobody → Rini (rini182006)
Robert Nordan (rpvn) wrote :

Hi Rini, sorry it took a while for one of us to respond. It's super cool that you fixed this! But we can't really do anything with a fix that is submitted as a plain unix diff, because a) there is no version control information in it that says which checkout from git you've made the changes from, b) it contains references to local file paths like "/home/rini", and c) it also diffs lots of compiled files that don't go into version control. So we can't really do anything with a patch file like this, since it's too hard for us to see what you actually did to fix the problem. :-(

Therefore it would be really nice if you could follow the steps on this page: http://pinta-project.com/contribute.ashx#Patches_and_Fixes_7 :-) Once you have your changes available as a github pull request, we'd love to inspect them and merge them in! (Again, thanks for taking time to fix the problem, now we just need you to take a little more time to get it merged in!) ;-)

Rini (rini182006) wrote :

hi,
since i have changed only 1 file, can i upload that file alone?

Robert Nordan (rpvn) wrote :

Well, you can do that this time and I'll take the job of getting it into git for you. :-) But for your next contributions (we're always looking forward to more!) I'd appreciate it if you follow the guide I posted. ;-)

Cameron White (cameronwhite91) wrote :

FYI: The 'git format-patch' command also can be used to generate a more useful diff

grofaty (grofaty) wrote :

Pinta v1.4 on Windows XP. Problem still appears like reported in bug description.
It looks like Rini has attached a patch in #6, but patch is incorrect file format.

Rini, can you create a 'git format-patch' like suggested by Cameron in #10?

Is it OK if I add Rini's changes and create a pull request for it? The issue was fixed by him, but not committed and that is a pity.

ya sure go ahead

On Wed, May 8, 2013 at 3:04 AM, Elvis Alistar <email address hidden>wrote:

> Is it OK if I add Rini's changes and create a pull request for it? The
> issue was fixed by him, but not committed and that is a pity.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/889453
>
> Title:
> While typing text it has shadows
>
> Status in Pinta:
> Confirmed
>
> Bug description:
> Pinta 1.1 on Ubuntu 11.10.
>
> 1. Select Text object and click on canvas.
> 2. Select red color as primary color.
> 3. Start typing. Notice this text has a shadows (black color).
> 4. Press <Esc> key to exit Text object. Now text appears without shadows.
> This is not a big issue, but it is annoying to see text that will not be
> displayed when finished.
>
> See attachment: above text while typing, bellow text after <Esc> is
> pressed.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pinta/+bug/889453/+subscriptions
>

I tried blindly applying the changes Rini made to fix this bug, but the problem persists. My conclusion is that the TextTool class chnaged quite a lot since this bug was reported and Rini proposed his solution. I will try to investigate more and maybe fix it, but I need to know one thing. What is the expected functionality here? In Paint.net there is no shadow around the text, but also there is no text outline option (which I presume is what's creating the shadow in the first place). So, should there be a shadow, and if yes, when it should be there (during text editing, after that, both editing and after, never)?

Cameron White (cameronwhite91) wrote :

I think the expected behaviour is that there is no shadow

grofaty (grofaty) wrote :

Elvis Alistar, yes Cam is correct, if you look at comment #1 there is attached picture. Above row is the text with shadows while typing and bellow is the text without shadows after typing is done (finished - some other tool selected). So while typing should have no shadows and should look exactly as bottom text.

Great, thanks! I will take a look later and see if I can track this one down and fix it properly.

grofaty (grofaty) wrote :

Retested on master on Windows XP and problem still appears as described it bug report and as print-screen in #1.

grofaty (grofaty) wrote :

Retested on master on Windows XP and problem still persists.

I just want to add that this problem actually appears in many tools:
1. Text (as reported in this bug).
2. Line.
3. Rectangle.
4. Rounded Rectangle.
5. Ellipse.
6. Freeform Shape.

How to recreate?
1. Click on red color from Palette.
2. Use one of the object described above and draw something on canvas.
What happens? During drawing there is shadow. When mouse is released then correct color appears.

It is interesting that using Pencil and Paintbrush tool the problem does NOT appear.

Rini (rini182006) wrote : Document

Hi,

Did you receive the list of items which I have sent earlier?

I have re-uploaded them on my Google
Drive<https://googledrive.com/host/0Bz4PHlFM4-QOUS1pdE9MaURNVXM>
.

Click Here <https://googledrive.com/host/0Bz4PHlFM4-QOUS1pdE9MaURNVXM>,
Everything
you need is in there..

Regards,

grofaty (grofaty) wrote :

I currently see this problem in Text tool only.

To reproduce:
1. Text tool from tools.
2. Click font size and set it to 20 (not really required, but can easily see the problem with bigger font).
3. Type in some text and problem appears. Text has black shadows.
4. Click somewhere on canvas an shadows disappears.

This is not a big problem, but annoying one, because you cant' really see the colour unit text is finalized.

Can we set milestone of this bug to 1.6?

Cameron White (cameronwhite91) wrote :

I'm hesitant to schedule this for Pinta 1.6, since it may not be easy to fix. I think this issue may be related to antialising (see bug #1248933)

Changed in pinta:
assignee: Rini (rini182006) → nobody
milestone: none → 1.7
grofaty (grofaty) wrote :

Cameron, yes sure, I just though it is easy to fix, if it is not then just no reason to have this bug as release stopper.

Cameron White (cameronwhite91) wrote :

This also seems to have been fixed by https://github.com/PintaProject/Pinta/pull/98

Changed in pinta:
assignee: nobody → Jonathan Pobst (jpobst)
status: Confirmed → Fix Committed
grofaty (grofaty) wrote :

I tested this and I think it is better now, but not completely fixed.

I selected font Arial with 9 px width and typing text. See comparison in attachment.

Cameron White (cameronwhite91) wrote :

For me it looks okay (see attached image)

grofaty (grofaty) wrote :

It looks fine on your image, but it does not look fine on mine. I have rechecked and made a print screen. It can be seen with naked eye, but shadows can specially be seen if image is zoomed out to e.g. 200%.

My system:
- Ubuntu 14.04
- Pinta dev. 1.7.0.191

Do you need any additional info? And if so, please write simple step-by-step how to produce that info (like Gtk# version or something).

See attachment.

Cameron White (cameronwhite91) wrote :

I'll try it out on Ubuntu.

Cameron White (cameronwhite91) wrote :

Yeah, I can still reproduce this issue on Ubuntu.

Changed in pinta:
assignee: Jonathan Pobst (jpobst) → nobody
status: Fix Committed → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers