Comment 4 for bug 1377566

Revision history for this message
Robert Nordan (rpvn) wrote :

You make a compelling case for including it into the core, especially when it comes to fixing broken behaviour and improving interoperability. I can't sign off on this alone though, Cameron needs to give his input here.

In the meantime, I must insist for all our sakes on getting the formalities right, as having a reviewable pull request on GitHub makes it easy for us to give proper feedback and for you to update it in response to that. There's no time to learn git like the present!

After a quick look at the code I have three initial pieces of feedback:
- You have to make it work with the current master of Pinta if it's to be mergable.
- The global variable with version can be replaced with PintaCore.ApplicationVersion
- The pixel/centimetre conversion can be replaced with a GDK lookup http://stackoverflow.com/questions/417384/get-dpi-settings-via-gtk

Love the effort you've put into it so far, let's see if we can't reel this one all the way in!