Pinta

Bug #1377566
Comment #16

Comment 16 for bug 1377566

Revision history for this message

Robert Nordan (rpvn) wrote on 2014-11-03: Re: [Bug 1377566] Re: OpenRaster and OpenDocument enhancement

#16

Sorry, I was just landed with a major project at work, so will have limited
time to do open source stuff for another couple of weeks. One question
though: how does the properties dialogue work, does it come up every time
you want to save a new ora or is it more voluntary?
On 2 Nov 2014 21:55, "Alan Horkan" <email address hidden> wrote:

> if my discussing the code on IRC would be more efficient than going back
> and forth through the github review page or this bug report please let
> me know and maybe we can arrange a suitable time.
>
> --
> You received this bug notification because you are a member of Pinta
> Maintainers, which is subscribed to Pinta.
> https://bugs.launchpad.net/bugs/1377566
>
> Title:
> OpenRaster and OpenDocument enhancement
>
> Status in Pinta:
> New
>
> Bug description:
> TL:DR; Summary: I wrote a new version of the file import export code
> OraFormat.cs
>
>
> OpenRaster is layered image format, and has a minimal specification.
> OpenDocument is lots of different file formats, and an enormous
> specification.
>
> OpenRaster is loosely inspired by OpenDocument, it can and it SHOULD
> make use of more of the OpenDocument file format.
> To better prove this point I wanted to be able to show code. Pinta
> seemed like a a suitable choice (I liked the license and it gave me a
> reason to try programming in C#). I have extended the OpenRaster code and
> added OpenDocument draw compatibility, so that if you rename the .ora
> output files to .odg they will open in LibreOffice/OpenOffice Draw.
> There is more that could be done, but changes to other parts of Pinta
> besides OraFormat.cs would probably be needed and I wanted to limit the
> scope of my changes. Next would probably be to write a Properties Dialog
> and allow users to add Metadata (something OpenRaster does not specify but
> an ideal opportunity to copy what OpenDocument already recommends).
>
> My changes are against Pinta 1.4 which might make it more difficult to
> merge. My code is missing some changes from OraFormat.cs where Layer
> was changed to UserLayer, I think it was related to the Text tool
> updates but I don't think I missed anything else.
>
>
> Besides the code related to adding OpenDocument support there are other
> notable changes:
> Rewrote and replaced XmlTextWriter with XmlWriter
> "Starting with the .NET Framework 2.0, we recommend that you use the
> System.Xml.XmlWriter class instead."
>
> http://msdn.microsoft.com/en-us/library/system.xml.xmltextwriter%28v=vs.110%29.aspx
>
> Added support for OpenRaster Layer Visibility, import and export
> (Previously Pinta incorrectly set opacity="0" when a layer was set to
> hidden.)
> http://freedesktop.org/wiki/Specifications/OpenRaster/Draft/LayersStack/
>
>
> The code is heavily indented, and sparsely commented.
> Code review appreciated, particularly if I've written anything in a non
> C# style.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pinta/+bug/1377566/+subscriptions
>

> if my discussing the code on IRC would be more efficient than going back
> and forth through the github review page or this bug report please let
> me know and maybe we can arrange a suitable time.
>
> --
> You received this bug notification because you are a member of Pinta
> Maintainers, which is subscribed to Pinta.
> https://bugs.launchpad.net/bugs/1377566
>
> Title:
>   OpenRaster and OpenDocument enhancement
>
> Status in Pinta:
>   New
>
> Bug description:
>   TL:DR;  Summary: I wrote a new version of the file import export code
>   OraFormat.cs
>
>
>   OpenRaster is layered image format, and has a minimal specification.
>   OpenDocument is lots of different file formats, and an enormous
> specification.
>
>   OpenRaster is loosely inspired by OpenDocument, it can and it SHOULD
> make use of more of the OpenDocument file format.
>   To better prove this point I wanted to be able to show code. Pinta
> seemed like a a suitable choice (I liked the license and it gave me a
> reason to try programming in C#). I have extended the OpenRaster code and
> added OpenDocument draw compatibility, so that if you rename the .ora
> output files to .odg they will open in LibreOffice/OpenOffice Draw.
>   There is more that could be done, but changes to other parts of Pinta
> besides OraFormat.cs would probably be needed and I wanted to limit the
> scope of my changes. Next would probably be to write a Properties Dialog
> and allow users to add Metadata (something OpenRaster does not specify but
> an ideal opportunity to copy what OpenDocument already recommends).
>
>   My changes are against Pinta 1.4 which might make it more difficult to
>   merge. My code is missing some changes from OraFormat.cs where Layer
>   was changed to UserLayer, I think it was related to the Text tool
>   updates but I don't think I missed anything else.
>
>
>   Besides the code related to adding OpenDocument support there are other
> notable changes:
>   Rewrote and replaced XmlTextWriter with XmlWriter
>   "Starting with the .NET Framework 2.0, we recommend that you use the
> System.Xml.XmlWriter class instead."
>
> http://msdn.microsoft.com/en-us/library/system.xml.xmltextwriter%28v=vs.110%29.aspx
>
>   Added support for OpenRaster Layer Visibility, import and export
>   (Previously Pinta incorrectly set  opacity="0" when a layer was set to
> hidden.)
>   http://freedesktop.org/wiki/Specifications/OpenRaster/Draft/LayersStack/
>
>
>   The code is heavily indented, and sparsely commented.
>   Code review appreciated, particularly if I've written anything in a non
> C# style.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pinta/+bug/1377566/+subscriptions
>