Comment 2 for bug 773255

Revision history for this message
Nick Freear (nfreear) wrote :

Hi,

Thanks for the swift reply!

I suspect the issue I had was with a configuration string in our software (CloudEngine), which is sometimes empty but needs translating (when not empty),
* https://bitbucket.org/cloudengine/cloudengine/src/tip/system/application/config/cloudengine.dist.php#cl-14

In any case I've put a fix in our internationalization library:
* https://bitbucket.org/cloudengine/cloudengine/src/tip/system/application/libraries/MY_Language.php#cl-352
* https://bitbucket.org/cloudengine/cloudengine/issue/173/update-php-gettext-3rd

Maybe do a specific test for $string===false ? A number of false conditions (maybe not empty string) would cause a PHP warning in array_key_exists.

I've updated my Gist - I hope that helps. Thanks for your work on the library!

Best wishes,

Nick

CloudEngine - create your social site (shameless plug!)
http://getcloudengine.org