Comment 11 for bug 585169

Revision history for this message
robinmills (robinmills) wrote : RE: [Bug 585169] Re: phatch does not work with pyexiv2 0.2

Olivier

It's a real bummer that the pyexiv2 0.2 (and later) api is so different from 0.13. I think I can write a new module pyexiv_forphatch to interface with Phatch. I'll fix pyexiv_forphatch to use either the 0.13 or 0.2+.

I'll have to discuss this with Stani.

Robin

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Olivier Tilloy
Sent: Saturday, January 15, 2011 08:11
To: <email address hidden>
Subject: [Bug 585169] Re: phatch does not work with pyexiv2 0.2

Note that my main goal is to port the existing code base to pyexiv2 0.3, and make sure this doesn’t introduce regressions in the existing functionality. Adding new functionality (e.g. activate XMP support) is out-of-scope at the moment, as it would require lots of testing. However switching to pyexiv2 0.3 will naturally make adding XMP support quite easy to write.

--
You received this bug notification because you are a member of Phatch Launchpad Team, which is subscribed to Phatch.
https://bugs.launchpad.net/bugs/585169

Title:
  phatch does not work with pyexiv2 0.2

Status in Phatch = Photo & Batch!:
  In Progress

Bug description:
  phatch fails to work with pyexiv 0.2.1 trace as below :

  ERROR 1: Unable to open file: /home/anish/discord/obey_wallpaper_02.jpg:
  'module' object has no attribute 'Image'
  Image: /home/anish/discord/obey_wallpaper_02.jpg
  Action:
  None
  Details:
  Traceback (most recent call last):
    File "/usr/lib/python2.6/site-packages/phatch/core/api.py", line 561, in get_photo
      photo = pil.Photo(info_file, info_not_file)
    File "/usr/lib/python2.6/site-packages/phatch/core/pil.py", line 454, in __init__
      layer.image)
    File "/usr/lib/python2.6/site-packages/phatch/core/pil.py", line 177, in __init__
      self.pyexiv2, pyexiv2_temp = exif.read_metadata_temp(path)
    File "/usr/lib/python2.6/site-packages/phatch/lib/_pyexiv2.py", line 265, in read_metadata_temp
      image = pyexiv2.Image(filename)
  AttributeError: 'module' object has no attribute 'Image'

  Fix might be similar to
  http://bazaar.launchpad.net/~dlynch3/rapid/trunk/revision/214