Comment 7 for bug 1262716

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

Fixed in 5.6 tree.

For 5.5 it is broken in lock0lock, and needs to be fixed in codership-5.5 as well.

======================================================
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1056:12: warning: passing argument 2 of ‘lock_rec_has_to_wait’ makes integer from pointer without a cast [enabled by default]
            lock1, 1)));
            ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘ulint’ but argument is of type ‘struct trx_t * const’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1056:12: warning: passing argument 3 of ‘lock_rec_has_to_wait’ makes pointer from integer without a cast [enabled by default]
            lock1, 1)));
            ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘const struct ib_lock_t *’ but argument is of type ‘ulint’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1056:12: warning: passing argument 4 of ‘lock_rec_has_to_wait’ makes integer from pointer without a cast [enabled by default]
            lock1, 1)));
            ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘ulint’ but argument is of type ‘const struct ib_lock_t *’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1056:12: error: too many arguments to function ‘lock_rec_has_to_wait’
            lock1, 1)));
            ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: declared here
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c: In function ‘lock_rec_other_has_conflicting’:
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1632:9: warning: passing argument 1 of ‘lock_rec_has_to_wait’ makes pointer from integer without a cast [enabled by default]
         TRUE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘const struct trx_t *’ but argument is of type ‘int’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1632:9: warning: passing argument 2 of ‘lock_rec_has_to_wait’ makes integer from pointer without a cast [enabled by default]
         TRUE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘ulint’ but argument is of type ‘struct trx_t *’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1632:9: error: incompatible type for argument 3 of ‘lock_rec_has_to_wait’
         TRUE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘const struct ib_lock_t *’ but argument is of type ‘enum lock_mode’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1632:9: warning: passing argument 4 of ‘lock_rec_has_to_wait’ makes integer from pointer without a cast [enabled by default]
         TRUE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘ulint’ but argument is of type ‘struct ib_lock_t *’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1632:9: error: too many arguments to function ‘lock_rec_has_to_wait’
         TRUE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: declared here
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1645:9: warning: passing argument 1 of ‘lock_rec_has_to_wait’ makes pointer from integer without a cast [enabled by default]
         FALSE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘const struct trx_t *’ but argument is of type ‘int’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1645:9: warning: passing argument 2 of ‘lock_rec_has_to_wait’ makes integer from pointer without a cast [enabled by default]
         FALSE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘ulint’ but argument is of type ‘struct trx_t *’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1645:9: error: incompatible type for argument 3 of ‘lock_rec_has_to_wait’
         FALSE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘const struct ib_lock_t *’ but argument is of type ‘enum lock_mode’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1645:9: warning: passing argument 4 of ‘lock_rec_has_to_wait’ makes integer from pointer without a cast [enabled by default]
         FALSE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: expected ‘ulint’ but argument is of type ‘struct ib_lock_t *’
 lock_rec_has_to_wait(
 ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:1645:9: error: too many arguments to function ‘lock_rec_has_to_wait’
         FALSE)) {
         ^
/media/Tintin/Work/code/percona-xtradb-cluster/trunk-25/Percona-Server/storage/innobase/lock/lock0lock.c:911:1: note: declared here
 lock_rec_has_to_wait(
 ^

 ===============================================================