Comment 3 for bug 1250326

Revision history for this message
David Bennett (dbpercona) wrote :

Regarding pv...

I just spent time (and not the first time) trying to figure out why certain SST jobs were failing and this was ultimately the cause.

The error report on this is easy to miss.

I agree that we should not make it an installation depenency. Especially since pv is not a mainstream package in some distributions.

However, it might be feasable to simply disable the progress feature if the pv command is not found in the path.

This could be accomplished in the wsrep_sst_xtrabackup* scripts by checking for pv using which and if not found, display and error message that progress reports will be disabled.

It would probably be not too difficult to place is as a insert_pv function in wsrep_sst_common that handled the insertion of the pipe viewer into the command before execution and simply displayed a disable warning if not found.

Since the progress feature is not a critial path to the proper operation of Cluster replication, I am thinking that the lack of the pv command should probably not prevent a cluster node from syncing.