xtrabackup binary leaks file descriptors on --backup
Bug #713267 reported by
Peter Zaitsev
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Medium
|
Alexey Kopytov | ||
1.6 |
Fix Released
|
Medium
|
Alexey Kopytov | ||
2.0 |
Fix Released
|
Medium
|
Alexey Kopytov | ||
2.1 |
Fix Released
|
Medium
|
Alexey Kopytov |
Bug Description
Server is configured with innodb_
Xtrabackup is backing up 10000+ tables and is crashing with error 24 (out of file descriptors mid way thought)
ulimit -n 30000 before running it fixes the problem.
xtrabackup should handle open_files_limit option and increase number of limits and refuse to run or reduce number of allowed open files if needed. Alternatively we may restrict innodb_open_files setting as xtrabackup does not need many open files for operation.
Related branches
lp:~akopytov/percona-xtrabackup/bug713267-1.6
- Stewart Smith (community): Approve
-
Diff: 148 lines (+75/-42)1 file modifiedxtrabackup.c (+75/-42)
lp:~akopytov/percona-xtrabackup/bug713267-2.0
- Stewart Smith (community): Approve
-
Diff: 162 lines (+80/-47)1 file modifiedsrc/xtrabackup.c (+80/-47)
lp:~akopytov/percona-xtrabackup/bug713267-2.1
- Stewart Smith (community): Approve
-
Diff: 143 lines (+70/-30)3 files modifiedsrc/fil_cur.c (+31/-29)
src/xtrabackup.c (+31/-0)
src/xtrabackup.h (+8/-1)
Changed in percona-xtrabackup: | |
importance: | Undecided → Medium |
status: | Confirmed → Triaged |
summary: |
- Xtrabackup fails if there are many open files allowed + xtrabackup binary leaks file descriptors on --backup |
To post a comment you must log in.
Peter,
I'm not quite clear about both the bug and the proposed solution.
So xtrabackup crashed because the OS did not allow it to proceed due to open files limit. Note that during backup xtrabackup does not use more that (2 * N + 1) descriptors where N is the number of --parallel threads. The remaining descriptors could be used by the server or some other activity in the system.
I don't see how that can be fixed by handling server settings. It's about the OS limit, rather than any server/InnoDB limit. It's also not clear how cases like that can be detected in advance so xtrabackup would refuse to run.