Comment 1 for bug 946776
Revision history for this message
| Baron Schwartz (baron-xaprb) wrote Re: pt-table-checksum v 2.0.3 ignores --lock-wait-timeout parameter | #1 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
This code is very surprising to me. It should set the value of lock_wait_timeout to the value of the option regardless of the option's value, instead of using a hard-coded constant. It should also not do any greater-than comparison before the attempt to set the value. Instead, the greater-than comparison should be done in the error-handling code in case the attempt to set the value causes an error. The error should be displayed only if the value fails to be set and as a result is greater than what the user specified.
Furthermore, we need to get rid of the double-quotes in the SQL.
Finally, we need to document the error-if-