Comment 10 for bug 1536305

Revision history for this message
Frank Cizmich (frank-cizmich) wrote :

Hi Romain,

Yes, I had that into account.
The sprintf issue appeared in more than one place.
The "unified" commit for that is here:
https://github.com/percona/percona-toolkit/pull/73/

Since the printf formats and values are dynamically assembled (by design), I opted for using indexes in the format symbols, which keeps Perl happy, although at the cost of readability. I admit I was on the balance on whether to use "no warnings 'redundant'" as a simpler "definite" solution, but that would theoretically break if the wording of the warning changes. :-/

If you encounter problems please report. Feedback is crucial.

Regards and again thanks Romain