Comment 4 for bug 1125665

Revision history for this message
Daniel Nichter (daniel-nichter) wrote : Re: pt-stalk --no-stalk clobbers other options

Ok, I decided to change this a little. The 2.1 way of --no-stalk is magical, and magic usually doesn't turn out well. 2.1 --no-stalk clobbers these options:

      OPT_ITERATIONS=1
      OPT_CYCLES=0
      OPT_SLEEP=0
      OPT_INTERVAL=0

There's no way to override that. So 2.1 --no-stalk is magically "collect once and exit", rather than simply being "don't stalk, just collect." as one would more reasonably expect, I think.

So in 2.2, i.e. in the attached branch, I have made --no-stalk do just that, and all other options* are left-as-is. *Not all options: --cycles is disabled because if we're not stalking then we're not waiting for it to be true. And --pid, --log, and --daemonize still have no affect. This is all documented.

These changes mean that now to collect once and exit, you must: --no-stalk --iterations 1. Also, as the docs state: " You probably also want to specify values for L<"--interval">, L<"--iterations">, and L<"--sleep">." This is because the tool uses its defaults, so simply doing --no-stalk will result in 60s collections every 5 minutes forever.