Comment 4 for bug 1079086

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Brian, Ovais,

The tool's default behavior seems wrong:

"""
$ bin/pt-query-advisor t/lib/samples/slowlogs/slow002.txt

ALI.001 0x66825DDC008FFA89

# Profile
# Query ID NOTE WARN CRIT Item
# ================== ==== ==== ==== ==========================================
# 0x66825DDC008FFA89 1 0 0 update d?tuningdetail_?_? n inner join d?gonzo a using(gonzo) set n.column? = a.column?, n.word? = a.word?
"""

That tells me... nothing. :-) I think we should just simplify this tool: always group by query_id/fingerprint, and rm the summary. I suspect that, given the tool's name, the user expects to see queries and advice for those queries in the output.