Comment 2 for bug 1078887

Revision history for this message
Daniel Nichter (daniel-nichter) wrote : Re: Don't clobber the sql_mode set by the script with set-vars

This bug and https://code.google.com/p/maatkit/issues/detail?id=799 conflict. From the customer issue referenced in the latter:

"The desired behavior is that the second query would be inserted and the 0 treated as 'NULL' or the next number via autoincrement."

That was solely because the customer was using pt-log-player and replaying INSERT statements. pt-log-player is gone in 2.2, so this isn't an issue in the future, but for 2.1.8 we need to keep the change/fix for this bug because I think it's a better overall approach, but then we need to document in pt-log-player 2.1.8 that if you need auto vals on zero you'll have to use pt-log-player 2.1.7. So yes this means we're breaking backwards compat for pt-log-player in 2.1.8 but it's either that or not doing this bug which would affect more important tools.