Tc_log_page_size should be unflushable or server crashes if 2 XA SEs installed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MySQL Server |
Unknown
|
Unknown
|
|||
Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
High
|
Laurynas Biveinis | ||
5.1 |
Won't Fix
|
Undecided
|
Unassigned | ||
5.5 |
Won't Fix
|
Undecided
|
Unassigned | ||
5.6 |
Fix Released
|
High
|
Laurynas Biveinis |
Bug Description
http://
[7 Nov 10:40] Laurynas Biveinis
Description:
Credit goes to MariaDB.
With bug 47134 fixed, if TC_LOG_MMAP is in use (because of two XA-supporting storage engines available, such as InnoDB and TokuDB), FLUSH STATUS should cause a server crash on the next XA commit.
The status variable tc_log_page_size is directly bound to tc_log_page_size source variable, which is setup once in TC_LOG_
How to repeat:
Code analysis. It's not easy to make a testcase due to stock MySQL not having a second XA-supporting storage engine.
Suggested fix:
Make Tc_log_page_size a SHOW_LONG_NOFLUSH variable.
Related branches
- Stewart Smith (community): Approve
- George Ormond Lorch III: Pending (g2) requested
-
Diff: 519 lines (+287/-38)6 files modifiedPercona-Server/sql/handler.cc (+1/-1)
Percona-Server/sql/log.cc (+79/-35)
Percona-Server/sql/log.h (+4/-1)
Percona-Server/sql/mysqld.cc (+1/-1)
Percona-Server/unittest/gunit/CMakeLists.txt (+1/-0)
Percona-Server/unittest/gunit/tc_log_mmap-t.cc (+201/-0)
tags: | added: tokudb upstream |
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/ /jira.percona. com/browse/ PS-743