pcb

Bug #699480 (sf-2986641)
Comment #4

Comment 4 for bug 699480

Revision history for this message

patrickpg (patrickpg) wrote on 2010-04-15:

Perhaps the first version may stay as it with the outline on all planes always on as I don't have enought time to investigate. Also I will post a question in the forum to see if some people does not want it.
No the mm's are displayed in brackets after the inch/mil values. The patch can give the feeling the inches has been removed ( especially I placed in a squarre object the values before display, that could have remove some old outputs )
I can not just add the polygons on the outline. The previous implenentation was only to change a message and to draw a 10 mil line, I am not rewritting everything. The behavior was to change the message "... squarre ... 10 mil line ... offset 0, 0 size 123, 456" into "the center of this 10 mil path". Now I am using the outline to calculate the bounding box, then I have to display also the offset and the sizes, and that was the motivation as my provider asks for the dimentions of the smallest squarre around. I wanted to keep the compatibility with the old outline plane. However I understand some people ( and me ) wants the new behavior. Then now I am checking for the outline or outline_old plane, the old is marked by a flag. The code has been extended to draw also the polygons ( transformed into a serie of 10 mil lines ) but the flag "old" skip this part. Also the flag print again the old message without cotations
The outline_data has been rename into fab_notes
If math.h and sin() cos() are fine for you, it is fine for me. I compile PCB on Linux with gcc on an opteron machine using a radeon video card, I have no idea of the porting people could have make. As the admin you know better than me.
I come back to the min and max. I didn't find an unset flag in the box type. The I only change the +-1000000000 by INT_MIN and INT_MAX. However I would like to keep the definition like I did. Indeed the definitions one line bellow the general PCB measurements ( today set to int ) make things visible. If tomorow somebody submit a patch to move the unit from the 1/100th mil to 1/1000th, he may want to change the int into long long. Since INT_MIN and INT_MAX are numbers, the software is then wrong until the bug is found. Here bellow the definition, we can see there are INT_MIN/MAX to be changed into LONGLONG_MIN/MAX.

Next version of the patch will come on the begining of the week.

Perhaps the first version may stay as it with the outline on all planes always on as I don't have enought time to investigate. Also I will post a question in the forum to see if some people does not want it.
No the mm's are displayed in brackets after the inch/mil values. The patch can give the feeling the inches has been removed ( especially I placed in a squarre object the values before display, that could have remove some old outputs )
I can not just add the polygons on the outline. The previous implenentation was only to change a message and to draw a 10 mil line, I am not rewritting everything. The behavior was to change the message "... squarre ... 10 mil line ... offset 0, 0 size 123, 456"  into "the center of this 10 mil path". Now I am using the outline to calculate the bounding box, then I have to display also the offset and the sizes, and that was the motivation as my provider asks for the dimentions of the smallest squarre around. I wanted to keep the compatibility with the old outline plane. However I understand some people ( and me ) wants the new behavior. Then now I am checking for the outline or outline_old plane, the old is marked by a flag. The code has been extended to draw also the polygons ( transformed into a serie of 10 mil lines ) but the flag "old" skip this part. Also the flag print again the old message without cotations
The outline_data has been rename into fab_notes
If math.h and sin() cos() are fine for you, it is fine for me. I compile PCB on Linux with gcc on an opteron machine using a radeon video card, I have no idea of the porting people could have make. As the admin you know better than me.
I come back to the min and max. I didn't find an unset flag in the box type. The I only change the +-1000000000 by INT_MIN and INT_MAX. However I would like to keep the definition like I did. Indeed the definitions one line bellow the general PCB measurements ( today set to int ) make things visible. If tomorow somebody submit a patch to move the unit from the 1/100th mil to 1/1000th, he may want to change the int into long long. Since INT_MIN and INT_MAX are numbers, the software is then wrong until the bug is found. Here bellow the definition, we can see there are INT_MIN/MAX to be changed into LONGLONG_MIN/MAX.

Next version of the patch will come on the begining of the week.