pcb

Comment 21 for bug 699454

Revision history for this message
DJ Delorie (djdelorie) wrote :

patch 0001-add-outline-gerbers-option-to-gerber-exporter.patch is no longer needed.

In 0002, why did you take out the logic to select all groups and layers when all_layers?

I don't think we should have separate X and Y precision. Better would be to have an enum option with the available "formats" (like 3.2in, 5.3mm/tz, etc) that users are used to seeing, rather than making them figure out the various parts of the format individually. Also, having it be one option lets us put in "shortcuts" for popular fabs.

Why did you add find_option() ? The values are hard-coded at compile time, there should be no reason to have to search for them at runtime. Also, the fprintf() there should be an abort() - the error is for the developer, not the user, and returning a *valid* index leads to subtle bugs.

Also, I suspect the nanometer work will require changes to these patches as well.