Common users aren't adding files to the test suite, just sometimes running
it when they build from source. Since the HID doesn't care what the file
name is, we're not really placing any restrictions on users by forcing the
use of the attrs suffix.
I don't mind using the wildcard to let these files through, but I want the
warning message to be more accurate.
And I'd like the file name to somehow associate the file with the tests
it's used for. That's just good housekeeping.
On Tue, Jan 8, 2019 at 5:40 PM Bert Timmerman <email address hidden>
wrote:
> Note: AFAICT, checking for an ".attrs" file name extension applies only
> for the test suite.The BOM HID happily accepts file names without an
> extension ;-)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1808733
>
> Title:
> [BOM HID] Attributes
>
> Status in pcb:
> In Progress
>
> Bug description:
> The included patch was submitted by DJ. It allows the BOM hid to
> output element attributes. Use case is generating digi-key orders.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pcb/+bug/1808733/+subscriptions
>
Common users aren't adding files to the test suite, just sometimes running
it when they build from source. Since the HID doesn't care what the file
name is, we're not really placing any restrictions on users by forcing the
use of the attrs suffix.
I don't mind using the wildcard to let these files through, but I want the
warning message to be more accurate.
And I'd like the file name to somehow associate the file with the tests
it's used for. That's just good housekeeping.
On Tue, Jan 8, 2019 at 5:40 PM Bert Timmerman <email address hidden>
wrote:
> Note: AFAICT, checking for an ".attrs" file name extension applies only /bugs.launchpad .net/bugs/ 1808733 /bugs.launchpad .net/pcb/ +bug/1808733/ +subscriptions
> for the test suite.The BOM HID happily accepts file names without an
> extension ;-)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https:/
>
> Title:
> [BOM HID] Attributes
>
> Status in pcb:
> In Progress
>
> Bug description:
> The included patch was submitted by DJ. It allows the BOM hid to
> output element attributes. Use case is generating digi-key orders.
>
> To manage notifications about this bug go to:
> https:/
>