pcb

Comment 8 for bug 1496105

Revision history for this message
Chad Parker (parker-charles) wrote : Re: [Bug 1496105] Re: The maintainer mode mess.

A couple things. First, you bump the version in configure.ac in the
AM_GNU_GETTEXT_VERSION macro. Then when autogen.sh is run, autopoint
automake, etc. read that version from configure.ac. autopoint then will
actually copy many of the gettext source files into the intl/ and po/
directories, that correspond to the version of gettext that you specify.

So, it's a little more than just bumping the required version of gettext,
because you're also bumping the version of gettext that's "included".

But yes, this all happens just by changing the one number in configure.ac.

--Chad

On Jan 7, 2017 6:44 PM, "Dan McMahill" <email address hidden> wrote:

> By "upgrade gettext", do you just mean bump the minimum required in
> autogen.sh from 0.14 to 0.18 or 0.19? Do we need to change anything
> else? If that is all we need to do then sure, lets bump it up but
> perhaps we can use the minimum version we actually need.
>
> The reason for the old maintainer mode stuff was to try and minimize
> extra tools users needed to build.
>
> I'd assume the reason for the with included gettext bit is for helping
> reduce dependencies on external libs.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1496105
>
> Title:
> The maintainer mode mess.
>
> Status in gEDA project:
> Confirmed
> Status in pcb:
> Confirmed
>
> Bug description:
> Let me open a bug to track this. Also to allow a LPxxx branch in the
> repo.
>
> 4 weeks ago I removed AM_MAINTAINER_MODE, because this prohibited
> rebuilding some files, e.g. parse_y.c on source changes.
>
> Today I removed all files not coming with Git. Many of them manually,
> because not catched by a 'make maintainer-clean'. Since this cleaning,
> a 'make distcheck' fails entirely. The same worked before.
>
> A regular build ('./autogen.sh && ./configure && make') still works.
>
> - - - - - -
> To be more precise, this does not work:
>
> ./autogen.sh && ./configure && make
> make distcheck
>
> It fails with
> [... deliberately cut off ...]ter-statement ../../intl/plural.c
> In file included from plural.y:35:0:
> ../../intl/plural-exp.h:94:23: error: conflicting types for
> ‘libintl_gettextparse’
> # define PLURAL_PARSE libintl_gettextparse
> ^
> plural.y:40:25: note: in expansion of macro ‘PLURAL_PARSE’
> plural.c:185:5: note: in expansion of macro ‘__gettextparse’
>
> - - - - - -
> This sequence was found to WORK:
>
> ./autogen.sh && ./configure && make
> make distcheck
> ./autogen.sh && ./configure && make
> make distcheck
>
> ==> Yes, that's double the work, but the second 'make distcheck'
> completes.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/geda-project/+bug/1496105/+subscriptions
>