2 * Opposite conditions in nested 'if' blocks lead to a dead code block
Bug #1308929 reported by
dcb
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pcb |
Won't Fix
|
Low
|
Unassigned |
Bug Description
1.
[surface.c:246] -> [surface.c:247]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.
Source code is
if (f->type == GTS_STRING) {
if (f->type != GTS_STRING) {
2.
[split.c:1399] -> [split.c:1400]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.
if (f->type == GTS_STRING) {
if (f->type != GTS_STRING) {
Changed in pcb: | |
status: | New → Confirmed |
Changed in geda-project: | |
importance: | Undecided → Low |
status: | New → Fix Released |
To post a comment you must log in.
Hi,
I prepared a patch which may result in a solution, it does compile and removes the opposite and conflicting conditions.
I haven't tested this patch in depth, as I have no (full) knowledge of the gts internals and formats.
I like to here comments and ideas as to tweak this patch some more into a patch which can be committed.
Kind regards,
Bert Timmerman.